Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ability to specify primitives per entity or variable #748

Merged
merged 28 commits into from Sep 30, 2019

Conversation

@frances-h
Copy link
Contributor

commented Sep 17, 2019

Adds the ability to specify which entities or columns a primitive should be applied to (or ignore) as requested in #655

frances-h added 8 commits Sep 12, 2019
@frances-h frances-h requested review from rwedge and kmax12 Sep 17, 2019
@codecov

This comment has been minimized.

Copy link

commented Sep 17, 2019

Codecov Report

Merging #748 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #748      +/-   ##
==========================================
+ Coverage   97.69%   97.77%   +0.08%     
==========================================
  Files         118      119       +1     
  Lines       10576    10870     +294     
==========================================
+ Hits        10332    10628     +296     
+ Misses        244      242       -2
Impacted Files Coverage Δ
featuretools/synthesis/dfs.py 100% <ø> (ø) ⬆️
featuretools/primitives/options_utils.py 100% <100%> (ø)
featuretools/synthesis/deep_feature_synthesis.py 97.01% <100%> (+0.65%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.06% <100%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aab3894...06caeb1. Read the comment docs.

frances-h added 7 commits Sep 17, 2019
@frances-h frances-h changed the title add ability to specify primitives per entity or variable [WIP] add ability to specify primitives per entity or variable Sep 19, 2019
@frances-h frances-h changed the title [WIP] add ability to specify primitives per entity or variable add ability to specify primitives per entity or variable Sep 20, 2019
frances-h added 2 commits Sep 20, 2019
featuretools/primitives/options_utils.py Outdated Show resolved Hide resolved
featuretools/primitives/options_utils.py Outdated Show resolved Hide resolved
frances-h added 4 commits Sep 25, 2019
…into per-primitive-options
Copy link
Contributor

left a comment

looking good overall. Mainly added some comments about presentation in the documentation.

docs/source/frequently_asked_questions.ipynb Outdated Show resolved Hide resolved
docs/source/frequently_asked_questions.ipynb Outdated Show resolved Hide resolved
docs/source/index.rst Outdated Show resolved Hide resolved
featuretools/primitives/options_utils.py Outdated Show resolved Hide resolved
featuretools/synthesis/deep_feature_synthesis.py Outdated Show resolved Hide resolved
featuretools/synthesis/deep_feature_synthesis.py Outdated Show resolved Hide resolved
featuretools/primitives/options_utils.py Outdated Show resolved Hide resolved
frances-h added 3 commits Sep 27, 2019
Copy link
Contributor

left a comment

Docs look good! Just a couple minor comments and it's good to go from me

docs/source/frequently_asked_questions.ipynb Outdated Show resolved Hide resolved
featuretools/primitives/options_utils.py Outdated Show resolved Hide resolved
featuretools/primitives/options_utils.py Show resolved Hide resolved
@rwedge
rwedge approved these changes Sep 30, 2019
Copy link
Collaborator

left a comment

Looks good!

@frances-h frances-h merged commit 6c7aa5c into master Sep 30, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.69%)
Details
codecov/project 97.77% (+0.08%) compared to aab3894
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the per-primitive-options branch Sep 30, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.