Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing groupby features #754

Merged
merged 7 commits into from Sep 25, 2019

Conversation

@frances-h
Copy link
Contributor

commented Sep 25, 2019

Fix issue in #733 that removed some groupby features

@frances-h frances-h requested a review from rwedge Sep 25, 2019
@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Sep 25, 2019

Can you add a regression test?

@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #754 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   97.68%   97.68%   +<.01%     
==========================================
  Files         118      118              
  Lines       10543    10549       +6     
==========================================
+ Hits        10299    10305       +6     
  Misses        244      244
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 96.36% <100%> (+0.01%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 98.71% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5456944...b4064ed. Read the comment docs.

frances-h added 2 commits Sep 25, 2019
docs/source/changelog.rst Outdated Show resolved Hide resolved
frances-h added 2 commits Sep 25, 2019
@rwedge
rwedge approved these changes Sep 25, 2019
Copy link
Collaborator

left a comment

Looks good

@frances-h frances-h merged commit 81b9f20 into master Sep 25, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.68%)
Details
codecov/project 97.68% (+<.01%) compared to 5456944
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the fix-missing-features branch Sep 25, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.