Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove toolz direct dependency #755

Merged
merged 6 commits into from Sep 25, 2019

Conversation

@rwedge
Copy link
Collaborator

commented Sep 25, 2019

This pr removes the one place we directly import the toolz library. It will still get installed due to other dependencies.

@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #755 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   97.68%   97.68%   +<.01%     
==========================================
  Files         118      118              
  Lines       10549    10550       +1     
==========================================
+ Hits        10305    10306       +1     
  Misses        244      244
Impacted Files Coverage Δ
featuretools/tests/utils_tests/test_cli_utils.py 100% <100%> (ø) ⬆️
featuretools/utils/cli_utils.py 55.31% <100%> (ø) ⬆️
...aturetools/tests/entityset_tests/test_timedelta.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81b9f20...8506ebb. Read the comment docs.

rwedge added 2 commits Sep 25, 2019
@rwedge rwedge requested a review from kmax12 Sep 25, 2019
@kmax12
kmax12 approved these changes Sep 25, 2019
Copy link
Contributor

left a comment

LGTM

@rwedge rwedge merged commit a197dc0 into master Sep 25, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.68%)
Details
codecov/project 97.68% (+<.01%) compared to 81b9f20
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the remove-toolz-direct-dependency branch Sep 25, 2019
@rwedge rwedge referenced this pull request Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.