Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boolean variable type in Multiply primitive #756

Merged
merged 9 commits into from Sep 27, 2019

Conversation

@thehomebrewnerd
Copy link
Contributor

commented Sep 25, 2019

Pull Request Description

Update binary_transform.py to include support for boolean variable types in the Multiply primitive. Also, added a test in test_transform_features.py to confirm this works properly when multiplying numeric by numeric, bool by numeric, and numeric by bool.

This PR closes issue #752

@codecov

This comment has been minimized.

Copy link

commented Sep 25, 2019

Codecov Report

Merging #756 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
+ Coverage   97.68%   97.69%   +<.01%     
==========================================
  Files         118      118              
  Lines       10550    10576      +26     
==========================================
+ Hits        10306    10332      +26     
  Misses        244      244
Impacted Files Coverage Δ
...aturetools/primitives/standard/binary_transform.py 100% <100%> (ø) ⬆️
featuretools/feature_base/feature_base.py 97.89% <100%> (+0.01%) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.4% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a197dc0...fd568eb. Read the comment docs.

@thehomebrewnerd thehomebrewnerd requested a review from kmax12 Sep 25, 2019
@kmax12 kmax12 requested review from rwedge and removed request for kmax12 Sep 26, 2019
docs/source/changelog.rst Outdated Show resolved Hide resolved
@rwedge
rwedge approved these changes Sep 27, 2019
Copy link
Collaborator

left a comment

Looks good!

@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2019

If you have the privileges you can go ahead and merge it in, otherwise I can do it.

@thehomebrewnerd thehomebrewnerd merged commit aab3894 into master Sep 27, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 97.68%)
Details
codecov/project 97.69% (+<.01%) compared to a197dc0
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@thehomebrewnerd thehomebrewnerd deleted the allow-bool-in-multiply branch Sep 27, 2019
@thehomebrewnerd

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

I was able to do it. Do you want me to go ahead and close out the related issue as well?

@rwedge

This comment has been minimized.

Copy link
Collaborator

commented Sep 27, 2019

Yep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.