Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests in windows environment #790

Merged
merged 74 commits into from Dec 3, 2019
Merged

Run unit tests in windows environment #790

merged 74 commits into from Dec 3, 2019

Conversation

@rwedge
Copy link
Collaborator

rwedge commented Oct 29, 2019

fixes #781

rwedge added 30 commits Oct 29, 2019
rwedge added 19 commits Nov 15, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #790 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #790      +/-   ##
==========================================
+ Coverage   98.15%   98.15%   +<.01%     
==========================================
  Files         121      121              
  Lines       10939    10941       +2     
==========================================
+ Hits        10737    10739       +2     
  Misses        202      202
Impacted Files Coverage Δ
featuretools/entityset/serialize.py 98.66% <100%> (ø) ⬆️
...ools/tests/primitive_tests/test_primitive_utils.py 100% <100%> (ø) ⬆️
featuretools/utils/s3_utils.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aad8ee...f819cff. Read the comment docs.

@rwedge rwedge changed the title [WIP] Run unit tests in windows environment Run unit tests in windows environment Dec 2, 2019
@rwedge rwedge requested a review from christopherbunn Dec 3, 2019
Copy link
Contributor

christopherbunn left a comment

LGTM

@rwedge rwedge merged commit cd674b3 into master Dec 3, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 98.15%)
Details
codecov/project 98.15% (+<.01%) compared to 8aad8ee
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the windows-ci branch Dec 20, 2019
@rwedge rwedge mentioned this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.