Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build_docs test #803

Merged
merged 7 commits into from Nov 8, 2019
Merged

Fix build_docs test #803

merged 7 commits into from Nov 8, 2019

Conversation

@rwedge
Copy link
Collaborator

rwedge commented Nov 7, 2019

Pull Request Description

Resolves #802

Importing featuretools.autonormalize fails seemingly due to pip not installing a version of python-dateutil that satisfies both pandas and botocore.
Once boto/botocore#1872 is resolved we can remove the requirement

We could add more automated tests checking that featuretools.autonormalize and other entrypoint imports work, but I think it would be better to test those on the original library's repo instead of ours.

I'm thinking a test scheme like this:

  • Featuretools library tests that featuretools[complete] install the additional library
  • The additional library tests the ability to use the entry point each time Featuretools master branch is updated

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@rwedge rwedge requested a review from kmax12 Nov 7, 2019
@rwedge rwedge changed the title Add CI checks for entrypoints of optional packages Fix build_docs test Nov 8, 2019
@kmax12
kmax12 approved these changes Nov 8, 2019
@rwedge rwedge merged commit 9a4efda into master Nov 8, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the test-addon-imports branch Nov 8, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.