Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop python 2.7 from serialize.py #812

Merged
merged 2 commits into from Nov 14, 2019

Conversation

@systemshift
Copy link
Contributor

systemshift commented Nov 12, 2019

Pull Request Description

from the discussion started in #797 and issue #808. A line to support a special case for 2.7 support has been removed.
all tests pass after removing the line.
11 warnings show, but the same number has been there before this commit.

It might be wise to investigate if the 11 warnings are exactly the same. Or if removing the line removed one warning, and a new one has replaced it.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

systemshift added 2 commits Nov 12, 2019
@rwedge
rwedge approved these changes Nov 14, 2019
Copy link
Collaborator

rwedge left a comment

I checked the warning logs against another branch, the warnings were the same

Looks good!

@rwedge rwedge merged commit 606c0c0 into FeatureLabs:master Nov 14, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@systemshift systemshift deleted the systemshift:remove_py_2.7_serialize.py branch Nov 21, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.