Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor make_ecommerce_entityset #813

Merged
merged 9 commits into from Nov 14, 2019
Merged

Conversation

@frances-h
Copy link
Contributor

frances-h commented Nov 13, 2019

  • Refactor make_ecommerce_entityset to directly use created dataframes to generate the entityset instead of saving the dataframes to csv first.
  • Update tests to only create entityset once and use deep copies as copying is faster.
  • Sort entities by id when serializing entityset

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@frances-h frances-h changed the title Refactor make ecommerce entityset Refactor make_ecommerce_entityset Nov 13, 2019
@frances-h frances-h requested a review from rwedge Nov 13, 2019
@frances-h frances-h changed the title Refactor make_ecommerce_entityset [WIP] Refactor make_ecommerce_entityset Nov 13, 2019
frances-h added 5 commits Nov 13, 2019
@frances-h frances-h changed the title [WIP] Refactor make_ecommerce_entityset Refactor make_ecommerce_entityset Nov 14, 2019
@frances-h frances-h mentioned this pull request Nov 14, 2019
@rwedge
rwedge approved these changes Nov 14, 2019
Copy link
Collaborator

rwedge left a comment

Looks good!

@frances-h frances-h merged commit 372f513 into master Nov 14, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the refactor-make-ecommerce-entityset branch Nov 14, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.