Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix global ignore variable #819

Merged
merged 10 commits into from Nov 20, 2019
Merged

Fix global ignore variable #819

merged 10 commits into from Nov 20, 2019

Conversation

@frances-h
Copy link
Contributor

frances-h commented Nov 18, 2019

Globally ignores a variable (including preventing Identity Feature from being created) if global options do not conflict with any primitive options


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

frances-h added 4 commits Nov 18, 2019
@frances-h frances-h requested a review from rwedge Nov 18, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2019

Codecov Report

Merging #819 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #819      +/-   ##
==========================================
+ Coverage   98.12%   98.12%   +<.01%     
==========================================
  Files         119      119              
  Lines       10877    10883       +6     
==========================================
+ Hits        10673    10679       +6     
  Misses        204      204
Impacted Files Coverage Δ
featuretools/primitives/options_utils.py 100% <100%> (ø) ⬆️
featuretools/synthesis/deep_feature_synthesis.py 97.02% <100%> (+0.01%) ⬆️
...ols/tests/synthesis/test_deep_feature_synthesis.py 99.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead2e91...fb1dec3. Read the comment docs.

frances-h and others added 5 commits Nov 18, 2019
@frances-h frances-h force-pushed the fix-global-ignore-variable branch from f84d563 to fb1dec3 Nov 20, 2019
@rwedge
rwedge approved these changes Nov 20, 2019
Copy link
Collaborator

rwedge left a comment

Looks good

@frances-h frances-h merged commit 9fce745 into master Nov 20, 2019
2 checks passed
2 checks passed
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the fix-global-ignore-variable branch Nov 20, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.