Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove get_values() from test_es.py #820

Merged

Conversation

@systemshift
Copy link
Contributor

systemshift commented Nov 19, 2019

Pull Request Description

Replace deprecating get_values with to_numpy() to remove warnings when running tests


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

systemshift added 2 commits Nov 19, 2019
@@ -128,7 +128,7 @@ def test_query_by_id_with_time(es):
instance_vals=[0, 1, 2, 3, 4],
time_last=datetime(2011, 4, 9, 10, 30, 2 * 6))

assert df['id'].get_values().tolist() == [0, 1, 2]

This comment has been minimized.

Copy link
@rwedge

rwedge Nov 19, 2019

Collaborator

does df['id'].tolist() work as well? It would be simpler

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #820 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         119      119           
  Lines       10875    10875           
=======================================
  Hits        10671    10671           
  Misses        204      204
Impacted Files Coverage Δ
featuretools/tests/entityset_tests/test_es.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 853091d...ddd2393. Read the comment docs.

@systemshift systemshift changed the title replace get_values() with to_numpy() remove get_values() from test_es.py Nov 20, 2019
@rwedge
rwedge approved these changes Nov 20, 2019
Copy link
Collaborator

rwedge left a comment

Looks good

@rwedge rwedge merged commit 205fa1b into FeatureLabs:master Nov 20, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 98.12%)
Details
codecov/project 98.12% (+0%) compared to 853091d
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@systemshift systemshift deleted the systemshift:replace_get_values_with_to_numpy branch Nov 21, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.