Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change empty strings to NaNs in make_ecommerce_entityset #821

Merged
merged 3 commits into from Nov 19, 2019

Conversation

@frances-h
Copy link
Contributor

frances-h commented Nov 19, 2019


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@frances-h frances-h requested a review from rwedge Nov 19, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         119      119           
  Lines       10875    10875           
=======================================
  Hits        10671    10671           
  Misses        204      204
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4877913...f2e65d5. Read the comment docs.

@rwedge
rwedge approved these changes Nov 19, 2019
Copy link
Collaborator

rwedge left a comment

Looks good

@frances-h frances-h merged commit 853091d into master Nov 19, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing 4877913...f2e65d5
Details
codecov/project 98.12% remains the same compared to 4877913
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the fix-ecommerce-nan branch Nov 19, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.