Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pd.Series.empty for faster check #823

Merged
merged 3 commits into from Nov 20, 2019
Merged

Use pd.Series.empty for faster check #823

merged 3 commits into from Nov 20, 2019

Conversation

@frances-h
Copy link
Contributor

frances-h commented Nov 20, 2019

  • use pd.Series.empty instead of .equals(pd.Series())

After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@frances-h frances-h requested a review from rwedge Nov 20, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #823 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #823      +/-   ##
==========================================
- Coverage   98.12%   98.12%   -0.01%     
==========================================
  Files         119      119              
  Lines       10877    10876       -1     
==========================================
- Hits        10673    10672       -1     
  Misses        204      204
Impacted Files Coverage Δ
featuretools/synthesis/deep_feature_synthesis.py 97% <100%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead2e91...c70b385. Read the comment docs.

frances-h added 2 commits Nov 20, 2019
@rwedge
rwedge approved these changes Nov 20, 2019
Copy link
Collaborator

rwedge left a comment

Looks good

@frances-h frances-h merged commit b30aaf6 into master Nov 20, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 98.12%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +1.87% compared to ead2e91
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@frances-h frances-h deleted the use-pd.Series.empty branch Nov 20, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.