Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff uses full entity #824

Merged
merged 7 commits into from Nov 20, 2019
Merged

Diff uses full entity #824

merged 7 commits into from Nov 20, 2019

Conversation

@rwedge
Copy link
Collaborator

rwedge commented Nov 20, 2019

Pull Request Description

Fixes how the Diff primitive is calculated so that it will use all available data when calculating diff. This should make returned values more predictable.


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

rwedge added 5 commits Nov 20, 2019
@rwedge rwedge requested a review from kmax12 Nov 20, 2019
Copy link
Contributor

kmax12 left a comment

LGTM

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2019

Codecov Report

Merging #824 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #824      +/-   ##
==========================================
+ Coverage   98.12%   98.12%   +<.01%     
==========================================
  Files         119      119              
  Lines       10882    10897      +15     
==========================================
+ Hits        10678    10693      +15     
  Misses        204      204
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <100%> (ø) ⬆️
...s/tests/primitive_tests/test_transform_features.py 98.48% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fce745...89cb1c4. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Nov 20, 2019
@kmax12
kmax12 approved these changes Nov 20, 2019
@rwedge rwedge merged commit cfa87c9 into master Nov 20, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 98.12%)
Details
codecov/project 98.12% (+<.01%) compared to 9fce745
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the diff-use-full-entity branch Nov 20, 2019
@rwedge rwedge restored the diff-use-full-entity branch Nov 20, 2019
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.