Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sklearn wrapper to separate library #835

Merged
merged 23 commits into from Dec 18, 2019
Merged

Move sklearn wrapper to separate library #835

merged 23 commits into from Dec 18, 2019

Conversation

@rwedge
Copy link
Collaborator

rwedge commented Dec 5, 2019

There's a bug (scikit-learn/scikit-learn/issues/15795) in the 0.22 release of scikit-learn that is breaking one of our test cases. Telling pip to ignore specifically the 0.22 release to avoid this bug.

rwedge added 2 commits Dec 5, 2019
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 5, 2019

Codecov Report

❗️ No coverage uploaded for pull request base (master@cd674b3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #835   +/-   ##
=========================================
  Coverage          ?   98.15%           
=========================================
  Files             ?      117           
  Lines             ?    10848           
  Branches          ?        0           
=========================================
  Hits              ?    10648           
  Misses            ?      200           
  Partials          ?        0
Impacted Files Coverage Δ
featuretools/utils/cli_utils.py 55.31% <ø> (ø)
featuretools/__init__.py 65.51% <ø> (ø)
featuretools/tests/utils_tests/test_cli_utils.py 100% <ø> (ø)
featuretools/version.py 100% <100%> (ø)
featuretools/tests/test_version.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd674b3...955609a. Read the comment docs.

@rwedge rwedge requested a review from kmax12 Dec 5, 2019
@@ -8,4 +8,4 @@ distributed>=1.24.2
dask>=1.1.0
psutil>=5.4.8
click>=7.0.0
scikit-learn>=0.20.0
scikit-learn>=0.20.0,!=0.22

This comment has been minimized.

Copy link
@kmax12

kmax12 Dec 5, 2019

Contributor

is sklearn only used by the DFSWrapper? if so, maybe we should make it an optional dependency since that functionality is "beta" anyways

This comment has been minimized.

Copy link
@rwedge

rwedge Dec 5, 2019

Author Collaborator

Yeah it's only used in that wrapper

@rwedge rwedge requested a review from kmax12 Dec 11, 2019
@rwedge rwedge changed the title Fix sklearn wrapper test Remove sklearn wrapper Dec 11, 2019
Copy link
Contributor

kmax12 left a comment

looks good. just one comment

@@ -26,20 +26,6 @@ Deep Feature Synthesis

dfs


This comment has been minimized.

Copy link
@kmax12

kmax12 Dec 13, 2019

Contributor

i think we can keep this in like we do for the nlp primitives. we just need to mention how to install

https://docs.featuretools.com/en/stable/api_reference.html#natural-language-processing-primitives

rwedge added 12 commits Dec 17, 2019
@rwedge rwedge requested a review from kmax12 Dec 18, 2019
@kmax12
kmax12 approved these changes Dec 18, 2019
@rwedge rwedge changed the title Remove sklearn wrapper Move sklearn wrapper to separate library Dec 18, 2019
@rwedge rwedge merged commit cb82feb into master Dec 18, 2019
4 checks passed
4 checks passed
codecov/patch No report found to compare against
Details
codecov/project No report found to compare against
Details
license/cla Contributor License Agreement is signed.
Details
test_all_python_versions Workflow: test_all_python_versions
Details
@rwedge rwedge deleted the fix-sklearn-wrapper-test branch Dec 18, 2019
@rwedge rwedge mentioned this pull request Dec 19, 2019
@rwedge rwedge mentioned this pull request Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.