Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic tag selection #106

Merged
merged 7 commits into from Sep 18, 2020
Merged

Add semantic tag selection #106

merged 7 commits into from Sep 18, 2020

Conversation

tamargrey
Copy link
Contributor

@tamargrey tamargrey commented Sep 17, 2020

Closes #82

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall. just minor things.

data_tables/tests/data_table/test_datatable.py Outdated Show resolved Hide resolved
data_tables/tests/data_table/test_datatable.py Outdated Show resolved Hide resolved
data_tables/tests/data_table/test_datatable.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 18, 2020

Codecov Report

Merging #106 into main will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #106      +/-   ##
==========================================
+ Coverage   99.58%   99.62%   +0.04%     
==========================================
  Files          16       18       +2     
  Lines         959     1081     +122     
==========================================
+ Hits          955     1077     +122     
  Misses          4        4              
Impacted Files Coverage Δ
woodwork/data_column.py 100.00% <100.00%> (ø)
woodwork/data_table.py 98.68% <100.00%> (+0.19%) ⬆️
woodwork/tests/data_column/test_data_column.py 100.00% <100.00%> (ø)
woodwork/tests/data_table/test_datatable.py 100.00% <100.00%> (ø)
woodwork/tests/test_utils.py 100.00% <100.00%> (ø)
woodwork/tests/testing_utils/__init__.py 100.00% <100.00%> (ø)
woodwork/tests/testing_utils/data_table_utils.py 100.00% <100.00%> (ø)
woodwork/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37ea426...a45b8d7. Read the comment docs.

Copy link
Contributor

@gsheni gsheni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 thing

@@ -69,12 +70,12 @@ def _parse_logical_type(self, logical_type):

def set_semantic_tags(self, semantic_tags):
"""Replace semantic tags with passed values"""
self._semantic_tags = _parse_semantic_tags(semantic_tags)
self._semantic_tags = _parse_semantic_tags(semantic_tags, 'semantic_tags')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe put _parse_semantic_tags(semantic_tags, error_language='semantic_tags'). So we don't get confused why its listed twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was something I'd been thinking about too. Also changed one of the tests to test an error message with test_text as the optional parameter

@tamargrey tamargrey merged commit b3b1561 into main Sep 18, 2020
@gsheni gsheni mentioned this pull request Sep 24, 2020
@gsheni gsheni deleted the select-semantic-tags branch September 30, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helper function to DataTable to select Data Columns with certain tag
3 participants