Removed Variable dtype (#416)

* removed dtype * use repr * fix test * delete varaible dtype
alteryx · Feb 8, 2019 · 2204a76 · 2204a76
1 parent 5923b68
commit 2204a76
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/featuretools/entityset/entity.py b/featuretools/entityset/entity.py
@@ -84,7 +84,7 @@ def __repr__(self):
         repr_out = u"Entity: {}\n".format(self.id)
         repr_out += u"  Variables:"
         for v in self.variables:
-            repr_out += u"\n    {} (dtype: {})".format(v.id, v.dtype)
+            repr_out += u"\n    {} (dtype: {})".format(v.id, v._dtype_repr)
 
         shape = self.shape
         repr_out += u"\n  Shape:\n    (Rows: {}, Columns: {})".format(

diff --git a/featuretools/variable_types/variable.py b/featuretools/variable_types/variable.py
@@ -44,7 +44,7 @@ def __eq__(self, other):
             self.entity_id == other.entity_id
 
     def __repr__(self):
-        ret = u"<Variable: {} (dtype = {})>".format(self.name, self.dtype)
+        ret = u"<Variable: {} (dtype = {})>".format(self.name, self._dtype_repr)
 
         # encode for python 2
         if type(ret) != str:
@@ -70,11 +70,6 @@ def create_from(cls, variable):
     def name(self):
         return self._name if self._name is not None else self.id
 
-    @property
-    def dtype(self):
-        return self._dtype_repr \
-            if self._dtype_repr is not None else "generic_type"
-
     @name.setter
     def name(self, name):
         self._name = name
@@ -181,7 +176,7 @@ def __init__(self, id, entity, format=None, name=None):
         super(Datetime, self).__init__(id, entity, name)
 
     def __repr__(self):
-        ret = u"<Variable: {} (dtype: {}, format: {})>".format(self.name, self.dtype, self.format)
+        ret = u"<Variable: {} (dtype: {}, format: {})>".format(self.name, self._dtype_repr, self.format)
 
         # encode for python 2
         if type(ret) != str: