Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zipcode to mock_customer and docs #417

Merged
merged 11 commits into from Feb 8, 2019

Conversation

Projects
None yet
2 participants
@gsheni
Copy link
Contributor

commented Feb 7, 2019

  • Add ZIPCode to variable type for mock_customer()
  • Change docs to show this change.

gsheni added some commits Feb 7, 2019

@gsheni gsheni self-assigned this Feb 7, 2019

@gsheni gsheni requested a review from kmax12 Feb 7, 2019

@codecov

This comment has been minimized.

Copy link

commented Feb 7, 2019

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #417   +/-   ##
=======================================
  Coverage   96.14%   96.14%           
=======================================
  Files          92       92           
  Lines        8232     8232           
=======================================
  Hits         7915     7915           
  Misses        317      317
Impacted Files Coverage Δ
featuretools/demo/mock_customer.py 95.45% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 659ebf4...153ff6d. Read the comment docs.

gsheni added some commits Feb 7, 2019

@kmax12

kmax12 approved these changes Feb 8, 2019

Copy link
Member

left a comment

LGTM

kmax12 and others added some commits Feb 8, 2019

@gsheni gsheni merged commit 69b6e04 into master Feb 8, 2019

3 checks passed

codecov/patch 100% of diff hit (target 96.14%)
Details
codecov/project 96.14% (+0%) compared to 659ebf4
Details
license/cla Contributor License Agreement is signed.
Details

@gsheni gsheni deleted the add_zipcode branch Feb 8, 2019

@rwedge rwedge referenced this pull request Feb 15, 2019

Merged

v0.6.1 #436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.