Fix bug with encode_features and features that create multiple columns #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
+ Coverage 97.43% 97.43% +<.01%
==========================================
Files 118 118
Lines 9534 9535 +1
==========================================
+ Hits 9289 9290 +1
Misses 245 245
Continue to review full report at Codecov.
|
CJStadler
approved these changes
Jul 2, 2019
| @@ -74,7 +74,7 @@ def encode_features(feature_matrix, features, top_n=10, include_unknown=True, | |||
| assert fname in X.columns, ( | |||
| "Feature %s not found in feature matrix" % (fname) | |||
| ) | |||
| feature_names.append(fname) | |||
| feature_names.append(fname) | |||
Merged
johnnyheineken
pushed a commit
to johnnyheineken/featuretools
that referenced
this pull request
Jul 7, 2019
alteryx#622) * fix indent * tests for duplicate columns * update changelog * Update changelog.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes issue #621
Features create multiple columns in the feature matrix aren't handled by
encode_features. This PR fixes a bug that would cause some columns of a feature with multiple outputs to be added to the column list twice, resulting in duplicate columns in the resulting matrix.After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of
docs/source/changelog.rstto include this pull request.