New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login method tries to encode bytes type (v0.12.0a1) #87

Closed
joextodd opened this Issue Apr 28, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@joextodd

joextodd commented Apr 28, 2015

In Python 3:
The login method works as expected when loading data from the backend, because the hash is loaded as a string. However if you for example, use the reset_password method, then the hash is stored in self._store.users as a bytes instance. The login method then tries to encode the bytes hash, which will fail until the server is restarted and the data is loaded from the backend.

@joextodd

This comment has been minimized.

Show comment
Hide comment
@joextodd

joextodd Apr 28, 2015

I have illustrated a simple fix for this on my fork at commit:cea0f2da06127a457d803e0aa1643f835ade1411

joextodd commented Apr 28, 2015

I have illustrated a simple fix for this on my fork at commit:cea0f2da06127a457d803e0aa1643f835ade1411

@FedericoCeratto FedericoCeratto added the bug label Apr 28, 2015

@FedericoCeratto FedericoCeratto self-assigned this Apr 28, 2015

FedericoCeratto added a commit that referenced this issue Apr 29, 2015

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto

FedericoCeratto Apr 29, 2015

Owner

@joetodd109 Can you please test if the branch "87" works for you now. I added a simple test; more thorough tests would be welcome.

Owner

FedericoCeratto commented Apr 29, 2015

@joetodd109 Can you please test if the branch "87" works for you now. I added a simple test; more thorough tests would be welcome.

@joextodd

This comment has been minimized.

Show comment
Hide comment
@joextodd

joextodd May 1, 2015

@FedericoCeratto Branch 87 passes my tests!
Thanks, Joe

joextodd commented May 1, 2015

@FedericoCeratto Branch 87 passes my tests!
Thanks, Joe

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto

FedericoCeratto May 1, 2015

Owner

@joetodd109 fix released in version 0.12.0a2

Owner

FedericoCeratto commented May 1, 2015

@joetodd109 fix released in version 0.12.0a2

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto

FedericoCeratto May 3, 2015

Owner

There is still a lingering bug impacting Postgresql on Py3 only.

On May 1, 2015 10:59:48 AM GMT+01:00, joetodd109 notifications@github.com wrote:

Branch 87 passes my tests!
Thanks, Joe


Reply to this email directly or view it on GitHub:
#87 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

Owner

FedericoCeratto commented May 3, 2015

There is still a lingering bug impacting Postgresql on Py3 only.

On May 1, 2015 10:59:48 AM GMT+01:00, joetodd109 notifications@github.com wrote:

Branch 87 passes my tests!
Thanks, Joe


Reply to this email directly or view it on GitHub:
#87 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment