New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store the login time in the users table #47

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@bpmason1
Contributor

bpmason1 commented Aug 18, 2013

Each time a user logs in save the time in the users table. This will allow for later features such as freezing/deleting stagnant accounts.

@ghost ghost assigned FedericoCeratto Aug 19, 2013

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto

FedericoCeratto Aug 19, 2013

Owner

Thank you. I've noticed that the continuous integration test is failing: https://travis-ci.org/FedericoCeratto/bottle-cork/jobs/10321837 (not sure if you can access that URL)
Have you tested your change? I think the unit tests should be updated.

Owner

FedericoCeratto commented Aug 19, 2013

Thank you. I've noticed that the continuous integration test is failing: https://travis-ci.org/FedericoCeratto/bottle-cork/jobs/10321837 (not sure if you can access that URL)
Have you tested your change? I think the unit tests should be updated.

@bpmason1

This comment has been minimized.

Show comment
Hide comment
@bpmason1

bpmason1 Aug 19, 2013

Contributor

I'll look into the test failure tonight.

Date: Mon, 19 Aug 2013 02:55:25 -0700
From: notifications@github.com
To: bottle-cork@noreply.github.com
CC: bpmason1@hotmail.com
Subject: Re: [bottle-cork] store the login time in the users table (#47)

Thank you. I've noticed that the continuous integration test is failing: https://travis-ci.org/FedericoCeratto/bottle-cork/jobs/10321837 (not sure if you can access that URL)

Have you tested your change? I think the unit tests should be updated.


Reply to this email directly or view it on GitHub.

Contributor

bpmason1 commented Aug 19, 2013

I'll look into the test failure tonight.

Date: Mon, 19 Aug 2013 02:55:25 -0700
From: notifications@github.com
To: bottle-cork@noreply.github.com
CC: bpmason1@hotmail.com
Subject: Re: [bottle-cork] store the login time in the users table (#47)

Thank you. I've noticed that the continuous integration test is failing: https://travis-ci.org/FedericoCeratto/bottle-cork/jobs/10321837 (not sure if you can access that URL)

Have you tested your change? I think the unit tests should be updated.


Reply to this email directly or view it on GitHub.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 19, 2013

Coverage Status

Coverage remained the same when pulling 70d2a2a on bpmason1:master into 987853d on FedericoCeratto:master.

coveralls commented Aug 19, 2013

Coverage Status

Coverage remained the same when pulling 70d2a2a on bpmason1:master into 987853d on FedericoCeratto:master.

@bpmason1

This comment has been minimized.

Show comment
Hide comment
@bpmason1

bpmason1 Aug 19, 2013

Contributor

it's fixed now. I'm in the process of downloading the packages so I can use run_coverage from a local terminal (to avoid testing individual file commits on Travis) but it's taking some time because there's a lot of dependencies.

Date: Mon, 19 Aug 2013 14:04:58 -0700
From: notifications@github.com
To: bottle-cork@noreply.github.com
CC: bpmason1@hotmail.com
Subject: Re: [bottle-cork] store the login time in the users table (#47)

Coverage remained the same when pulling 70d2a2a on bpmason1:master into 987853d on FedericoCeratto:master.


Reply to this email directly or view it on GitHub.

Contributor

bpmason1 commented Aug 19, 2013

it's fixed now. I'm in the process of downloading the packages so I can use run_coverage from a local terminal (to avoid testing individual file commits on Travis) but it's taking some time because there's a lot of dependencies.

Date: Mon, 19 Aug 2013 14:04:58 -0700
From: notifications@github.com
To: bottle-cork@noreply.github.com
CC: bpmason1@hotmail.com
Subject: Re: [bottle-cork] store the login time in the users table (#47)

Coverage remained the same when pulling 70d2a2a on bpmason1:master into 987853d on FedericoCeratto:master.


Reply to this email directly or view it on GitHub.

@bpmason1

This comment has been minimized.

Show comment
Hide comment
@bpmason1

bpmason1 Aug 19, 2013

Contributor

hold on before you merge ....

Date: Mon, 19 Aug 2013 14:04:58 -0700
From: notifications@github.com
To: bottle-cork@noreply.github.com
CC: bpmason1@hotmail.com
Subject: Re: [bottle-cork] store the login time in the users table (#47)

Coverage remained the same when pulling 70d2a2a on bpmason1:master into 987853d on FedericoCeratto:master.


Reply to this email directly or view it on GitHub.

Contributor

bpmason1 commented Aug 19, 2013

hold on before you merge ....

Date: Mon, 19 Aug 2013 14:04:58 -0700
From: notifications@github.com
To: bottle-cork@noreply.github.com
CC: bpmason1@hotmail.com
Subject: Re: [bottle-cork] store the login time in the users table (#47)

Coverage remained the same when pulling 70d2a2a on bpmason1:master into 987853d on FedericoCeratto:master.


Reply to this email directly or view it on GitHub.

@bpmason1 bpmason1 closed this Aug 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment