New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'session_key', to allow alternates to the default 'beaker.session'... #84

Merged
merged 1 commit into from Mar 24, 2015

Conversation

Projects
None yet
3 participants
@jmcaine
Contributor

jmcaine commented Mar 22, 2015

..., as supported in beaker, and necessary/useful for plugging multiple apps together (so that different apps can have distinct beaker sessions).

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 22, 2015

Coverage Status

Coverage decreased (-0.03%) to 25.93% when pulling 109fc83 on jmcaine:master into a9137d4 on FedericoCeratto:master.

coveralls commented Mar 22, 2015

Coverage Status

Coverage decreased (-0.03%) to 25.93% when pulling 109fc83 on jmcaine:master into a9137d4 on FedericoCeratto:master.

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto

FedericoCeratto Mar 23, 2015

Owner

Thanks for your PR! Would you mind renaming it "session_key_name", otherwise it might look like the variable contains the value of the session key? Thanks!

Owner

FedericoCeratto commented Mar 23, 2015

Thanks for your PR! Would you mind renaming it "session_key_name", otherwise it might look like the variable contains the value of the session key? Thanks!

@jmcaine

This comment has been minimized.

Show comment
Hide comment
@jmcaine

jmcaine Mar 23, 2015

Contributor

Certainly. Also, I thought of something else -- perhaps I should add the init arg at the end of the list, so that I don't break the API for backward compatibility, for those who use positional args there and use them all. I stuck it by the ''session_domain" arg, thinking that made a good neighbor, but it does have the side-effect of breaking the API. What do you think, shall I move it to the end of the arg-list while renaming it?

Contributor

jmcaine commented Mar 23, 2015

Certainly. Also, I thought of something else -- perhaps I should add the init arg at the end of the list, so that I don't break the API for backward compatibility, for those who use positional args there and use them all. I stuck it by the ''session_domain" arg, thinking that made a good neighbor, but it does have the side-effect of breaking the API. What do you think, shall I move it to the end of the arg-list while renaming it?

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto

FedericoCeratto Mar 24, 2015

Owner

@jmcaine: that would good as well! (even if keyword args should be used as keywords when there's many of them)

Owner

FedericoCeratto commented Mar 24, 2015

@jmcaine: that would good as well! (even if keyword args should be used as keywords when there's many of them)

FedericoCeratto added a commit that referenced this pull request Mar 24, 2015

Merge pull request #84 from jmcaine/master
added 'session_key', to allow alternates to the default 'beaker.session'...

@FedericoCeratto FedericoCeratto merged commit 093e45e into FedericoCeratto:master Mar 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@FedericoCeratto FedericoCeratto self-assigned this Mar 24, 2015

FedericoCeratto added a commit that referenced this pull request Mar 24, 2015

@FedericoCeratto

This comment has been minimized.

Show comment
Hide comment
@FedericoCeratto
Owner

FedericoCeratto commented Mar 24, 2015

Thanks!

@jmcaine

This comment has been minimized.

Show comment
Hide comment
@jmcaine

jmcaine Mar 25, 2015

Contributor

Thanks -- I meant to get to it, but it looks like you beat me to it. :)

Contributor

jmcaine commented Mar 25, 2015

Thanks -- I meant to get to it, but it looks like you beat me to it. :)

Michael
added 'session_key', to allow alternates to the default 'beaker.sessi…
…on', as supported in beaker, and necessary/useful for plugging multiple apps together (so that different apps can have distinct beaker sessions).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment