Skip to content
Permalink
Branch: master
Commits on Sep 10, 2019
  1. Fix spelling

    yoe committed Sep 10, 2019
    Kaart Lezer -> Kaartlezer
    
    Fixes: gh-93
Commits on Sep 2, 2019
  1. Add missing brackets

    yoe committed Sep 2, 2019
    Causes writes to unallocated memory, and hence memory corruption.
    
    Fixes gh-90
Commits on Aug 30, 2019
  1. Revert "Escape all exclamation marks"

    yoe committed Aug 30, 2019
    This reverts commit 898c139.
    
    Not the solution, apparently
  2. Escape all exclamation marks

    yoe committed Aug 30, 2019
    In some cases, cmd considers the exclamation mark (!) to be a special
    character, which then causes it to be eaten.
    
    Escape them to avoid that.
Commits on Aug 28, 2019
  1. Add missing constraints

    yoe committed Aug 28, 2019
    So that the button moves around when someone resizes the window, and so that an Xcode warning is removed
Commits on Aug 22, 2019
  1. Sigh

    yoe committed Aug 22, 2019
    Revert things a bit, do it properly now. I hope.
  2. Whoops, use the correct macro

    yoe committed Aug 22, 2019
    The check_rv macros don't access the 'rv' variables directly, only the
    _late ones do -- so we can't loop on them in those cases.
  3. Drop assertion

    yoe committed Aug 22, 2019
    Apparently scan-build *still* manages to find a way that results in NULL
    values, no matter how many assertions we add.
    
    Refactor the code a bit so that assertions aren't necessary any more,
    and things become obvious.
  4. Improve check

    yoe committed Aug 22, 2019
    The opposite version of this is also invalid :)
    
    Assert that count and list are linked, really.
  5. Add assertion to satisfy scan-build

    yoe committed Aug 22, 2019
    Scan-build, the clang static analyser, found some control flow whereby
    we would have a nonzero number of slots returned by C_GetSlotList but we
    wouldn't have allocated them, because CKR_BUFFER_TOO_SMALL wouldn't have
    been returned.
    
    There is an implicit assumption in the code that that will never happen,
    because we'd then have CKR_BUFFER_TOO_SMALL and things would have been
    reallocated. However, this assumption is never made explicit, and so
    scan-build can't see it.
    
    Since it would be a pretty terrible bug to not return
    CKR_BUFFER_TOO_SMALL with count set to nonzero, it's a good idea to test
    for that explicitly.
Commits on Aug 20, 2019
  1. Travis: stop trying OSX

    yoe committed Aug 20, 2019
    codesign is a bitch
  2. Disable code signing on travis

    yoe committed Aug 19, 2019
  3. Unfail OSX

    yoe committed Aug 19, 2019
  4. Try building without sudo, too

    yoe committed Aug 19, 2019
Commits on Aug 19, 2019
  1. Remove the card before initialising, to ensure things work the way we…

    yoe committed Aug 19, 2019
    … expect
  2. Wait a bit after the robot is removed, otherwise we get confused a bit

    yoe committed Aug 19, 2019
  3. Improve the deserialize test

    yoe committed Aug 19, 2019
    - Also allow running it when no card or robot is present
    - Drop the sleep calls, instead use a mutex and a condition to signal
      across threads when it's safe to move on
  4. Travis: drop trusty requirement

    yoe committed Aug 19, 2019
    We no longer require trusty (Xenial, the default, works fine, and we
    don't actually even support people using trusty anymore), so stop trying
    to build for it and build using the defaults instead.
  5. Drop unused variable

    yoe committed Aug 19, 2019
Commits on Aug 14, 2019
  1. Don't leak memory in quicklookd

    yoe committed Aug 14, 2019
  2. implement application:openFile:

    yoe committed Aug 14, 2019
    Rather than specifying a filename on the command line, the macOS way of doing things is to open the application and then to send the application:openFile: message to it.
    
    Implement that to allow opening files from the finder.
  3. Add a description

    yoe committed Aug 14, 2019
    We want to show the file type as something that says "eID", rather than the more generic "XML text" that shows up by default.
Commits on Aug 13, 2019
  1. Fix location of dropped variable

    yoe committed Aug 13, 2019
    There is another function which still calls stat(), and which obviously
    still needs its `struct results`. We accidentally removed that one
    rather than the one we really don't need anymore.
    
    Fix.
  2. Drop unused variable

    yoe committed Aug 13, 2019
    Now that we're not calling stat() anymore, we don't need the results
    variable anymore, so drop it.
  3. Don't stat when we're going to rename later

    yoe committed Aug 13, 2019
    This loop ran stat() or wstat() over a filename. If the stat failed
    (most likely because the file did not exist), then we exit the loop, as
    an optimization. Later on, we then do a rename.
    
    While this works, the downside of this method is that it introduces a
    time of check/time of use race, where the file may be removed the
    rename.
    
    This isn't critical for us (it's an optimization, after all), but it's
    not so nice -- and Coverity complains about it.
    
    Since rename actually will set errno to ENOENT if the old file does not
    exist, it makes sense to just drop the stat and exit the loop when
    rename fails.
    
    Coverity CID#179263
  4. update the viewer export script: also sign the .dmg and add some dela…

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 12, 2019
    …ys between commands
    
    (cherry picked from commit ec23571)
  5. mac export build script: sign everything

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 9, 2019
    (cherry picked from commit 8cd0f13)
  6. mac export build script: give notarization service some time to store…

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 9, 2019
    … the ticket before trying to staple the ticket
  7. mac installer eidmw: removed no longer used post-install script

    Frederik Frederik
    Frederik authored and Frederik committed Aug 8, 2019
    (cherry picked from commit e1f8af5)
  8. post install script mac eidmw installer: remove actions done for macO…

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 8, 2019
    …S version prior to 10.12
    
    (cherry picked from commit 12ec2a0)
  9. bugfix mac buildscript: typo in notarizing command

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 8, 2019
  10. codesign pkcs11 dylibs with the hardened runtime option

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 8, 2019
    (cherry picked from commit 1ea5f3e)
  11. cleaned up old exportoptions.plist files

    Frederik Frederik
    Frederik authored and Frederik committed Aug 6, 2019
  12. regression: make export scripts executable again

    Frederikus Frederik
    Frederikus authored and Frederik committed Aug 6, 2019
    (cherry picked from commit 03753cb)
Older
You can’t perform that action at this time.