-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop applying the Adwaita color palette to Kirigami apps #131
Comments
I've been trying to figure out how to identify Kirigami apps from QGnomePlatform, but I have no idea how to do that. Any idea? |
Kirigami isn't strictly the problem here, it's qqc2-desktop-style (which many Kirigami apps force because there is no better style available). qqc2-desktop-style uses KColorScheme (which is kind of a superset of QPalette) to do colors. The problem here is that 1) QPalette and KColorScheme are out of sync (QGnomePlatform applies Awaita colors to QPalette but KColorScheme still uses the builting Breeze default) and 2) KColorScheme knows more color roles than QPalette I see multiple possible solutions to this:
|
Note that the problem isn't even specific to QML. Widgets apps sometimes use KColorScheme too and then have the same problem. try e.g. Kate on Gnome with a dark theme, there will be parts of the colors wrong |
To do this create an "adwaita.colors", install it and from QGnomePlatform do |
From a recent post by a GNOME designer1, it was found that QGnomePlatform would be causing black-on-black problems in Kirigami apps, due to applying the Adwaita-qt color palette indiscriminately to any Qt app.
Since according to the README, this project aims to apply GNOME settings to unmodified Qt apps, I suggest at least finding some way to avoid applying the Adwaita color palette on Kirigami apps.
Other parts of QGnomePlatform (like decorations) are still useful for Kirigami apps, so those should still work.
Footnotes
https://mastodon.social/@tbernard/109897404484985777 ↩
The text was updated successfully, but these errors were encountered: