Introduce a ClientCount dbus Property #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can be used from outside daemon/gamemode.c, to e.g. implement an ClientCount property.
Introduce a new "ClientCount" dbus property that can be queried and also watched to see if gamemode is currently active (or not).
gicmo
force-pushed
the
client_count_property
branch
from
8d391b6
to
aef107e
Compare
|
A shell extension is a good idea, let me know when you have that implemented. These changes look good to me, merged. |
|
I have started with the extension. For now it will display an icon in that top bar, that will turn red once it is activated: |
|
Love it! This has always been a future TODO for me, glad someone has grabbed it much earlier than I would have :) |
afayaz-feral
pushed a commit
that referenced
this pull request
May 26, 2020
Introduce a ClientCount dbus Property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to write a simple GNOME shell extension that displays an icon if gamemode is active (maybe in the future a list of games requestion game mode as a menu would be nice too). For this a property that can be watched would be neat.