Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a ClientCount dbus Property #129

Merged
merged 2 commits into from Apr 12, 2019

Conversation

@gicmo
Copy link
Contributor

commented Apr 10, 2019

I want to write a simple GNOME shell extension that displays an icon if gamemode is active (maybe in the future a list of games requestion game mode as a menu would be nice too). For this a property that can be watched would be neat.

gicmo added 2 commits Apr 10, 2019
So it can be used from outside daemon/gamemode.c, to e.g. implement
an ClientCount property.
Introduce a new "ClientCount" dbus property that can be queried and
also watched to see if gamemode is currently active (or not).
@gicmo gicmo force-pushed the gicmo:client_count_property branch from 8d391b6 to aef107e Apr 10, 2019
@aejsmith aejsmith merged commit 61797b8 into FeralInteractive:master Apr 12, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@aejsmith

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

A shell extension is a good idea, let me know when you have that implemented. These changes look good to me, merged.

@gicmo gicmo deleted the gicmo:client_count_property branch Apr 12, 2019
@gicmo

This comment has been minimized.

Copy link
Contributor Author

commented Apr 13, 2019

I have started with the extension.

For now it will display an icon in that top bar, that will turn red once it is activated: gamemode-on icon

@mdiluz

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

Love it! This has always been a future TODO for me, glad someone has grabbed it much earlier than I would have :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.