-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ioprio and niceness fixes, and long cmdline options #142
ioprio and niceness fixes, and long cmdline options #142
Conversation
Add tests to check this feature Apply config validation in config for simplicity Note: if anything messes with the niceness (ie. it starts non-zero, or it's not the expected value during setup, we'll bail out)
Part of fixing up FeralInteractive#141
Implements tests for feature Fixes CLAMP macro
Another part of the fix for FeralInteractive#141
|
Edited title to reflect WIP - at the moment this doesn't cope with multiple clients, will need to sort that out. |
1. We don't use them anyway (though that could be a feature request) 2. They weren't stored per-client, so would be incorrect anyway
|
20d014b fixes the problem for now. We don't mess with niceness or ioprio values that are non-default anyway, so there's no need to store the initial value. A future change might be to make these values an offset, or something else, but I worry that's being too clever - if a program is adjusting them itself, we should probably not mess with it. |
ioprio tests will now fail due to FeralInteractive#140
Also move some comments around
Make it simply take a functor to the per tid get method
…ocess Otherwise other tests might have to wait for the reaper thread to clean it up
|
I've now implemented multithreaded program fixes for ioprio and niceness optimizations, as well as tests for those implementations |
ioprio and niceness fixes, and long cmdline options
This PR has the following changes:
--request=PIDfor a specific processHelp now looks like:
I've also implemented tests for the two fixes above, both a302168 and a6e238d can be run to show the tests failing, before the subsequent fixes