New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and expose Timestamp and Requester properties for GameModeClient #161
Conversation
We show the status for examples & daemon, also show it for 'util'.
Record the time a client was created, i.e. registered, in the GameModeClient struct and add a getter for it.
Expose the timestamp that a client was created as 'Timestamp' property of the com.feralinteractive.GameMode.Game interface.
Record the requester process id in the GameModeClient struct and add a getter for it.
Expose the requeter process identifier as 'Requester' property of the com.feralinteractive.GameMode.Game interface.
@@ -69,6 +70,11 @@ pid_t game_mode_client_get_pid(GameModeClient *client); | |||
*/ | |||
const char *game_mode_client_get_executable(GameModeClient *client); | |||
|
|||
/** | |||
* The path to the executable of client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong comment.
@@ -714,6 +726,15 @@ const char *game_mode_client_get_executable(GameModeClient *client) | |||
return client->executable; | |||
} | |||
|
|||
/** | |||
* The path to the executable of client. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrong comment.
Just a couple of incorrect function comments, otherwise looks good to me. I'll fix these up and merge. As for |
Record the timestamp a client was created and who requested it and expose them as
Timestamp
andRequester
properties of thecom.feralinteractive.GameMode.Game
interface. I am thinking of creating a smallgamemodeclt
command line tool to show the current status, and list all the clients and all the information we got about them. Maybe also agamemodectl -p <pid>
to request GameMode on behalf ofpid
. What do you guys think?