Add and expose Timestamp and Requester properties for GameModeClient #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We show the status for examples & daemon, also show it for 'util'.
Record the time a client was created, i.e. registered, in the GameModeClient struct and add a getter for it.
Expose the timestamp that a client was created as 'Timestamp' property of the com.feralinteractive.GameMode.Game interface.
Record the requester process id in the GameModeClient struct and add a getter for it.
Expose the requeter process identifier as 'Requester' property of the com.feralinteractive.GameMode.Game interface.
aejsmith
reviewed
Jul 16, 2019
| @@ -69,6 +70,11 @@ pid_t game_mode_client_get_pid(GameModeClient *client); | |||
| */ | |||
| const char *game_mode_client_get_executable(GameModeClient *client); | |||
|
|
|||
| /** | |||
| * The path to the executable of client. | |||
aejsmith
reviewed
Jul 16, 2019
| @@ -714,6 +726,15 @@ const char *game_mode_client_get_executable(GameModeClient *client) | |||
| return client->executable; | |||
| } | |||
|
|
|||
| /** | |||
| * The path to the executable of client. | |||
|
Just a couple of incorrect function comments, otherwise looks good to me. I'll fix these up and merge. As for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Record the timestamp a client was created and who requested it and expose them as
TimestampandRequesterproperties of thecom.feralinteractive.GameMode.Gameinterface. I am thinking of creating a smallgamemodecltcommand line tool to show the current status, and list all the clients and all the information we got about them. Maybe also agamemodectl -p <pid>to request GameMode on behalf ofpid. What do you guys think?