From 039ba979305467a9d4b574f47208e6468292c313 Mon Sep 17 00:00:00 2001 From: BryanFRD Date: Wed, 22 Apr 2026 16:11:45 +0200 Subject: [PATCH 1/2] fix(action): pass criterion group-filter as positional arg --- action.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 163e76b..720d2d8 100644 --- a/action.yml +++ b/action.yml @@ -90,7 +90,8 @@ runs: GROUP_FILTER="${{ inputs.group-filter }}" BENCH_ARGS=(--bench ferrflow_benchmarks -- --output-format bencher) if [ -n "$GROUP_FILTER" ]; then - BENCH_ARGS+=(--filter "$GROUP_FILTER") + # criterion takes the filter as a positional arg, not --filter + BENCH_ARGS+=("$GROUP_FILTER") fi cargo bench "${BENCH_ARGS[@]}" 2> bench-stderr.log | tee raw-output.txt bench_exit=${PIPESTATUS[0]} From 8857eaae2542761220bf69f78eebf2cd6fb59c2b Mon Sep 17 00:00:00 2001 From: BryanFRD Date: Wed, 22 Apr 2026 16:28:32 +0200 Subject: [PATCH 2/2] fix(action): skip compare+comment step when comment-on-pr is false --- action.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/action.yml b/action.yml index 720d2d8..b95e140 100644 --- a/action.yml +++ b/action.yml @@ -142,7 +142,13 @@ runs: fi - name: Compare and comment (PR) - if: (inputs.type == 'micro' || inputs.type == 'all') && github.event_name == 'pull_request' + # Skip the compare+comment step entirely when the caller disables PR + # commenting (matrix shards set comment-on-pr: false — an aggregate job + # merges all shard outputs and runs the comparison once with proper + # pull-requests: write permission). Keeping this step here would fail + # on regression alerts because matrixed jobs don't have permission to + # post PR reviews. + if: (inputs.type == 'micro' || inputs.type == 'all') && github.event_name == 'pull_request' && inputs.comment-on-pr == 'true' uses: benchmark-action/github-action-benchmark@v1 with: tool: cargo