Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotations #82

Closed
wants to merge 6 commits into from
Closed

Rotations #82

wants to merge 6 commits into from

Conversation

platawiec
Copy link

Added the following:

  • Rotations for 2/4 order tensors in 3 dimensions (rotate(x, u, angle))
  • Generic rotations for 1/2/4 order tensors in n-dimensions (rotate(x, u, v, angle)). For this u and v are orthonormal vectors which define the n-2 dimensional space the rotation occurs in.
  • Tests for 2-4 tensor dot product
  • Tests for rotations in three dimensions

I tested out a generic fallback constructor which allowed n-dimensional tensors, but I may have been getting some test errors from that definition, or at least I wasn't sure where they were coming from. I'll look for a safer way to define such a constructor for a future PR.

@fredrikekre fredrikekre self-requested a review November 19, 2017 21:29
@KristofferC
Copy link
Collaborator

The test errors for the Voigt stuff look weird, perhaps they got broken with 0.6.1 or something... I'll try to look over this in the upcoming days. Many thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants