New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon in not Admin mode seems wrong #134

Closed
acethatch opened this Issue Mar 30, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@acethatch

acethatch commented Mar 30, 2018

The icon of the current song in not Admin mode seems wrong (A pause icon).
Now it looks if you could click it to start playing.

Maybe the play icon or an empty one is better?

2018-03-30 23_10_34-festify

2018-03-30 23_10_34-festify clear

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Mar 31, 2018

The icon always indicates the current playback state, and I personally don‘t want to change that. Think of media players like VLC, they also show the pause icon when something is playing because that‘s what you‘d do when you‘d click the button.

Furthermore, this would make the UI inconsistent, because the button would suddenly change its appearance once you‘re party admin. Right now the only thing that happens when you‘re admin is that the button isn‘t disabled anymore, which is the better option in my opinion. :)

@NeoLegends NeoLegends closed this Mar 31, 2018

@leolabs

This comment has been minimized.

Member

leolabs commented Apr 3, 2018

We could remove the button altogether for non-admin users as it is of no use to them. The playback state is visible in the progress bar which is grayed out when the player is paused. That could improve the UX for party guests and unclutter the UI a bit more :)

I can understand @acethatch's concern about the current way being a bit misleading.

@leolabs leolabs reopened this Apr 3, 2018

@leolabs leolabs closed this in 512ebc8 May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment