Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Icon in not Admin mode seems wrong #134
The icon always indicates the current playback state, and I personally don‘t want to change that. Think of media players like VLC, they also show the pause icon when something is playing because that‘s what you‘d do when you‘d click the button.
Furthermore, this would make the UI inconsistent, because the button would suddenly change its appearance once you‘re party admin. Right now the only thing that happens when you‘re admin is that the button isn‘t disabled anymore, which is the better option in my opinion. :)
We could remove the button altogether for non-admin users as it is of no use to them. The playback state is visible in the progress bar which is grayed out when the player is paused. That could improve the UX for party guests and unclutter the UI a bit more :)
I can understand @acethatch's concern about the current way being a bit misleading.