New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playlist doesn't load in FF when using direct link to party #201

Closed
cmar0ck opened this Issue Jul 3, 2018 · 12 comments

Comments

Projects
None yet
3 participants
@cmar0ck

cmar0ck commented Jul 3, 2018

Hi,

when opening a party URL (https://festify.us/party/-L************p) in Firefox without entering the party code beforehand the playlist and party title can't be loaded / load infinitely (see screenshot for details).

festify_ff_loading_problem

Tested in FF 60.0.2 (Ubuntu 18.04) and FF 61.0 (Win7), both 64bit.

Note: Refreshing / reloading the page seems to fix the issue temporarily but after clearing FF's cache the issue reappears.

Can u help, pls?

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Jul 3, 2018

Hey!

Could you open the console (Right Click > Inspect Element > Console Tab) and show us the output if there is any?

@NeoLegends NeoLegends added the Bug label Jul 3, 2018

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Jul 3, 2018

Yeah I can reproduce this. Working on a fix now.

@NeoLegends NeoLegends closed this in 7827f03 Jul 3, 2018

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Jul 3, 2018

Fixed. Thanks for the heads-up!

@NeoLegends NeoLegends self-assigned this Jul 3, 2018

@cmar0ck

This comment has been minimized.

cmar0ck commented Jul 3, 2018

Wow, that was fast, thanks a lot! :)

I assume I have to be patient a little longer for the changes to be deployed?
(When testing the problem still persists...)

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Jul 3, 2018

Yeah this is not live yet. :)

@cmar0ck

This comment has been minimized.

cmar0ck commented Jul 3, 2018

I see :) Last question, I promise:
Is there a chance it will go live before the 13th of July?
That would be really awesome as I intended to use Festify for an event on that date.

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Jul 3, 2018

Is there a chance it will go live before the 13th of July?

Very likely, but is this really a big problem to you? Seems like it would only occur once "in a lifetime", no?

@cmar0ck

This comment has been minimized.

cmar0ck commented Jul 3, 2018

Well, there will be numerous international guests and if only 100 of them try to use Festify with Firefox resulting in the queue not loading properly the first time they try it, they might be confused, disappointed or might even complain (not all of them are tech savvy), so the overall impression will suffer and that's something I'd like to avoid. I'd also like to keep the voting process as easy and streamlined as possible, so I'd definitely prefer the direct URL over the intermediate step of entering the party code. On the other hand I need to get print material (timetables, handouts, etc) done asap on which I planned to include the Festify URL and some instructions. So I'm depending on you and your decision when you're going to deploy the fix... Please don't let me down ;)

@NeoLegends

This comment has been minimized.

Member

NeoLegends commented Jul 4, 2018

Fix is released now

@cmar0ck

This comment has been minimized.

cmar0ck commented Jul 4, 2018

Amazing! Thanks a bunch!
Do you have a donation link so I can fund you a party pizza and a sixpack as a little token of appreciation?

@leolabs

This comment has been minimized.

Member

leolabs commented Jul 4, 2018

Thanks for your support! We have a donation button at the bottom of our website festify.rocks :)

@cmar0ck

This comment has been minimized.

cmar0ck commented Jul 4, 2018

awesome

Donation is on the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment