Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt type=module #35

Merged
merged 8 commits into from
Aug 31, 2021
Merged

Adopt type=module #35

merged 8 commits into from
Aug 31, 2021

Conversation

Fil
Copy link
Owner

@Fil Fil commented Apr 27, 2021

follow changes in d3-format:

  • type=module
  • add exports
  • remove zip
  • license: ISC
  • update dependencies

TODO:

  • update README.md
  • depends on d3-array@3, d3-geo@3, d3-tricontour@(n+1)
  • switch the default branch to main

follow changes in d3-format:
* type=module
* add exports
* remove zip
* license: ISC
* update dependencies
@martinfrances107
Copy link
Collaborator

I have inspected the diff ... All looks good - nothing I can see that raises alarms.

With such a large change to the plumbing... as a third party double check I can report

"The transition to the new environment is smooth all the code for me works as before."

I have been frequently running the old version on the test over the last few weeks.. and my feeling is things have gotten much faster ( with the move to Mocha)

As someone who has been generating .. lots of PR's with minor things
I thought making a PR about all the variables which could be defined as const...too small to report - but I am glad to see those things elevated to the modern standards.

Last part of my review... all the text in the README.md reads smoothly

TLGTM

@Fil
Copy link
Owner Author

Fil commented Apr 28, 2021

I'll gladly merge a change for let and const

@Fil Fil merged commit 33705ee into main Aug 31, 2021
@Fil Fil deleted the fil/type-module branch August 31, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants