fix: Use clientAddress for next dataset ID #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjmelements
approved these changes
Oct 10, 2025
github-project-automation
bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FS
wjmelements
added a commit
that referenced
this pull request
Oct 11, 2025
* fix: Use clientAddress for next dataset ID (#299) fix: resolves bug of using client address instead of signer for datsetId lookup * chore(master): release synapse-sdk 0.31.1 (#300) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update abi and fix tests * remove cdnEndEpoch from type * Update packages/synapse-sdk/wagmi.config.ts Co-authored-by: Rod Vagg <rod@vagg.org> --------- Co-authored-by: Shashank Trivedi <100513286+lordshashank@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rod Vagg <rod@vagg.org>
rvagg
pushed a commit
that referenced
this pull request
Oct 14, 2025
fix: resolves bug of using client address instead of signer for datsetId lookup
rvagg
added a commit
that referenced
this pull request
Oct 22, 2025
* fix: Use clientAddress for next dataset ID (#299) fix: resolves bug of using client address instead of signer for datsetId lookup * chore(master): release synapse-sdk 0.31.1 (#300) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update abi and fix tests * remove cdnEndEpoch from type * Update packages/synapse-sdk/wagmi.config.ts Co-authored-by: Rod Vagg <rod@vagg.org> --------- Co-authored-by: Shashank Trivedi <100513286+lordshashank@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rod Vagg <rod@vagg.org>
rvagg
added a commit
that referenced
this pull request
Oct 22, 2025
* fix: Use clientAddress for next dataset ID (#299) fix: resolves bug of using client address instead of signer for datsetId lookup * chore(master): release synapse-sdk 0.31.1 (#300) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update abi and fix tests * remove cdnEndEpoch from type * Update packages/synapse-sdk/wagmi.config.ts Co-authored-by: Rod Vagg <rod@vagg.org> --------- Co-authored-by: Shashank Trivedi <100513286+lordshashank@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rod Vagg <rod@vagg.org>
rvagg
added a commit
that referenced
this pull request
Oct 28, 2025
* fix: Use clientAddress for next dataset ID (#299) fix: resolves bug of using client address instead of signer for datsetId lookup * chore(master): release synapse-sdk 0.31.1 (#300) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * update abi and fix tests * remove cdnEndEpoch from type * Update packages/synapse-sdk/wagmi.config.ts Co-authored-by: Rod Vagg <rod@vagg.org> --------- Co-authored-by: Shashank Trivedi <100513286+lordshashank@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rod Vagg <rod@vagg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a targeted fix in the
StorageContextclass to ensure the correct address is used when creating a new dataset. Specifically, it changes the logic to consistently use theclientAddressinstead of thesignerAddresswhen retrieving the next client dataset ID. This helps prevent potential mismatches or errors related to address usage.warmStorageService.getNextClientDataSetIdto useclientAddressinstead ofsignerAddressin theStorageContextclass, ensuring consistency and correctness in dataset ID assignment.