Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyout show animation is not always smooth #391

Open
davuxcom opened this issue Jun 21, 2019 · 5 comments

Comments

Projects
None yet
3 participants
@davuxcom
Copy link
Contributor

commented Jun 21, 2019

The flyout animation is achieved by:

  • Fading in Window.Opacity
  • Translating vertically to the final position by animation Window.Top

This has the following problems:

  • Sometimes the animation isn't smooth
  • Sometimes the animation finishes in the wrong location
  • The animation lacks the acrylic background
    Both of these are thought to occur more under CPU stress.

The right fix is to use DirectComposition to compose an animation and not move the window, however this is anticipated to be expensive.

@davuxcom

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

I observed that on 1903 over remote desktop, with animations on, the flyout show animation reliably stops ~10px prior to the correct end position.

@ufolud

This comment has been minimized.

Copy link

commented Jun 22, 2019

I'm facing not-smooth flyout animation at any time I'm opening menu from taskbar.

@davuxcom

This comment has been minimized.

Copy link
Contributor Author

commented Jun 22, 2019

@ufolud Do you also see it fail to achieve the final position?

This is what I'm seeing on 1903 over remote desktop, recorded with Screen2Gif:

animationFail1

Perhaps you could take a video or confirm if yours looks similar?

@ufolud

This comment has been minimized.

Copy link

commented Jun 22, 2019

@davuxcom
As you can see, I don't have problems with position after animation, but still it's really not smooth
and it shows another problem, which is missing icons (or rather showing default exe icon; Discord in this example)
image
Compared to network popup built in by default
image
Both gifs were recorded in 60fps

@DrQwarck

This comment has been minimized.

Copy link

commented Jul 4, 2019

I have this problem too. The UI suddenly become sluggish, even after i restart my PC. Both gifs in 60 fps using Screen2Gif.
github1r
github3r

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.