New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a site switcher #5

Closed
Filnor opened this Issue Jun 1, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@Filnor
Copy link
Owner

Filnor commented Jun 1, 2018

As requested on Stack Apps, a possibility to choose a specific SE site should be added.
This is not a hard thing to implement, since the change isn't so big. But there are two questions that we need to answer:

Do we really want to check all sites?

Concern:

If a beta site gets taken down or a new one starts, that would need a manual change, as the site switcher needs a change (we can't read the numeric site id from the API)

Solution:

For that start, I think it would be OK to only provide sites that have the largest userbase. Please suggest other sites you would like to be added from start.

Has the user really a profile on this page?

Concern:

With the SE authentication (#4), this would be rather easy since items array that the API returns just would be empty. If the user specifies a link or an id to a profile, we can't check that directly.

Solution:

In another project, I also needed to check the user id. This can be reused here.

@Filnor

This comment has been minimized.

Copy link
Owner Author

Filnor commented Jun 6, 2018

Added with c65f520

@Filnor Filnor closed this Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment