New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise use of 'v' prefix on version tags #329

Closed
triblondon opened this Issue Mar 2, 2015 · 2 comments

Comments

Projects
None yet
3 participants
@triblondon
Contributor

triblondon commented Mar 2, 2015

From @kaelig's comment , there is a lack of common understanding about whether the v prefix should be used on version tags. I was against, now I'm pro, on the following grounds:

  • It's added by npm automatically, suggesting it's an npm best practice
  • Using it creates a namespace for versions which reduces likelihood of conflict with other tags not intended to be version numbers
  • It makes for a convenient hook for auto-suggest, if you have non-version tags you can auto-complete just version tags by typing a 'v'
@AlbertoElias

This comment has been minimized.

Show comment
Hide comment
@AlbertoElias

AlbertoElias Mar 2, 2015

Contributor

I don't mind, I think your second point is the most important one to adopt the v-prefix.

Do we need to rename current tags or just start using the v prefix from now onwards?

Contributor

AlbertoElias commented Mar 2, 2015

I don't mind, I think your second point is the most important one to adopt the v-prefix.

Do we need to rename current tags or just start using the v prefix from now onwards?

@matthew-andrews

This comment has been minimized.

Show comment
Hide comment
@matthew-andrews

matthew-andrews Mar 2, 2015

Member

consistency would be nice and I find the v prefix helpful for the reasons @triblondon said but it's not important enough to go back in time and change history so I think this is fine…

start using the v prefix from now onwards

Member

matthew-andrews commented Mar 2, 2015

consistency would be nice and I find the v prefix helpful for the reasons @triblondon said but it's not important enough to go back in time and change history so I think this is fine…

start using the v prefix from now onwards

@triblondon triblondon closed this in c2a4807 Mar 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment