This repository has been archived by the owner on Mar 22, 2024. It is now read-only.
Eslint upgrade to v5.4.0 #128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃惪 v2.10.2
|
Could we update the |
|
There are 13 repositories that use the I would suggest rather releasing a major version of n-gage and then the owners of the various repos can upgrade and test as and when they want to. |
|
closing, we've updated to eslint 5 and we're using renovate now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃惪 v2.10.2
Eslint complains about React shorthand for fragments
<> </>. The problem has been fixed ineslint v5.xbutn-gageis usingv4.x. see eslint/eslint#9662This upgrades to v5.4.0. It does have breaking changes.
The following warning appears when running v5.4.0 on N-ui, Next-myst-client, N-hanelbars, N-flags-client:
(node:24106) [ESLINT_LEGACY_OBJECT_REST_SPREAD] DeprecationWarning: The 'parserOptions.ecmaFeatures.experimentalObjectRestSpread' option is deprecated. Use 'parserOptions.ecmaVersion' instead. (found in ".eslintrc.js")