Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Remove deploy hashed assets deploy step #229

Merged
merged 2 commits into from Jul 27, 2020

Conversation

NickColley
Copy link
Contributor

@NickColley NickColley commented Jul 23, 2020

deploy-hashed-assets is deprecated so we want to remove it from everything, this depends on applications removing their use of the asset-hashes.json file which should be done before upgrading to this version.

This is a breaking change.

Migration documentation for release notes:

Remove deploy-hashed-assets step in deploy which looks for a asset-hashes.json file in the project.

Check if you have a asset-hashes.json file, if you do not, there is nothing to do.

If you do have a asset-hashes.json file, migrate to using public/manifest.json which is generated by Page Kit by default.

Nick Colley added 2 commits July 23, 2020 10:56
deploy-hashed-assets is deprecated so we want to remove it from everything, this depends on applications removing their use of the asset-hashes.json file which should be done before upgrading to this version.

This is a breaking change. 🐿 v2.13.0
@NickColley NickColley requested a review from a team as a code owner July 23, 2020 09:59
@@ -2,6 +2,7 @@ module.exports = {
files: {
allow: [
'dotfiles/.stylelintrc',
'dotfiles/.editorconfig',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 weird this wasn't needed before

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I'm not sure why this started blocking me?

@NickColley NickColley merged commit 5e3929a into master Jul 27, 2020
@NickColley NickColley deleted the remove-deploy-hashed-assets-deploy-step branch July 27, 2020 16:01
This was referenced Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants