Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly escape periods in hostname regexp #232

Merged
merged 1 commit into from
May 13, 2024
Merged

Properly escape periods in hostname regexp #232

merged 1 commit into from
May 13, 2024

Conversation

rowanmanning
Copy link
Member

@rowanmanning rowanmanning requested a review from a team as a code owner May 13, 2024 08:32
alexmuller
alexmuller approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@alexmuller alexmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rowanmanning rowanmanning merged commit a3fff51 into main May 13, 2024
16 checks passed
@rowanmanning rowanmanning deleted the fix-test-regexp branch May 13, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmuller alexmuller alexmuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rowanmanning @alexmuller