This repository has been archived by the owner on Nov 26, 2021. It is now read-only.
Add tests for the javascript program #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeChampion
reviewed
Aug 2, 2019
| @@ -86,3 +86,5 @@ describe("rewrite", () => { | |||
| expect(rewrite("../../src/lol", aliases)).toBe("../../dist/lol") | |||
| }) | |||
| }) | |||
|
|
|||
| export default {} | |||
There was a problem hiding this comment.
How come the test files have this empty export default?
There was a problem hiding this comment.
they have this because the vscode plugin for running Mocha tests gets real confused if it is using -r esm and the test has no default export.
JakeChampion
reviewed
Aug 2, 2019
JakeChampion
reviewed
Aug 2, 2019
JakeChampion
reviewed
Aug 2, 2019
JakeChampion
approved these changes
Aug 2, 2019
Improve wording of merge test
JakeChampion
reviewed
Aug 2, 2019
Missing quote 🙈 Co-Authored-By: Jake Champion <jakechampion.jake2@googlemail.com>
JakeChampion
reviewed
Aug 2, 2019
JakeChampion
approved these changes
Aug 2, 2019
|
Thanks, @JakeChampion !! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some tests have arrived.
some snapshots too.
still more to do, needs a set of o-test-component snapshots.