Enforce accessibility best practices by making some parameters mandatory #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
origamiserviceuser
added
meta
chee
deleted the
proposals/enforce-accessibility-best-practices-by-making-some-parameters-mandatory
branch
JakeChampion
pushed a commit
that referenced
this pull request
Nov 9, 2021
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.10.1 to 7.12.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.12.10/packages/babel-plugin-transform-runtime) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: J. Renée Beach <splendidnoise@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #69.
see rendered proposal
comments from issue
JakeChampion on 2020-08-04T10:02:22
Sorry for the slow reply on this!
I think this is a really good idea, thank you for raising it Glynn.
This looks like it can be rolled out on a component-by-component basis, using o-banner first as you have already pointed out it recommends setting at
buttonLabel. With regards to o-banner, it has a default value forbuttonLabelof "OK", I guess we would make it not have a default value and instead throw an error.