Support Microsoft Edge browser #1422

Closed
rnicholus opened this Issue Jun 9, 2015 · 17 comments

Projects

None yet

2 participants

@rnicholus
Member

If this already works, then we simply need to update the documentation to indicate support. Support for Edge must be complete before or very close to the release of Windows 10 (scheduled for July 29). If this does not coincide with a planned release of Fine Uploader, a hotfix release should be pushed out instead.

@rnicholus rnicholus added this to the 5.3.0 milestone Jun 9, 2015
@rnicholus
Member

I just tested Spartan/Edge/whatever via a Windows 10 Insider Preview against Fine Uploader 5.2.2. Brief tests suggest that everything obvious is working well except for file dropping. This is not a big surprise as each new version of Explorer in the past has required adjustments to Fine Uploader's DnD module.

The next task will involve fixing DnD for Spartan. Then, I'll spend some time on more in-depth testing.

@rnicholus
Member

It looks like Spartan may not yet support dropping of files from the desktop. I assume that will be ironed out before release.

@rnicholus rnicholus added 4 - Blocked and removed 3 - Doing labels Jun 16, 2015
@rnicholus
Member

Official word is that dropping of files will not be supported by Edge in the initial release. https://twitter.com/morris_charles/status/611997674460479488

@rnicholus rnicholus modified the milestone: 5.3.0, 5.4.0 Jul 6, 2015
@rnicholus rnicholus modified the milestone: 6.0.0, 5.4.0 Oct 29, 2015
@rnicholus
Member

pushing this to 6.0.0 since Edge still does not support file dropping, AFAIK.

@rnicholus rnicholus removed this from the 6.0.0 milestone Nov 5, 2015
@rnicholus
Member

I'm dropping this from the schedule as Microsoft doesn't seem to have any specific plans to support this feature.

@rnicholus
Member

According to the Edge changelog, support for this feature was added in build 10565. Assuming this passes verification, Edge will be supported as part of Fine Uploader 5.5.0.

@rnicholus rnicholus added 2 - Do and removed 4 - Blocked labels Nov 25, 2015
@rnicholus rnicholus added this to the 5.5.0 milestone Nov 25, 2015
@rnicholus rnicholus added 3 - Doing and removed 2 - Do labels Dec 31, 2015
@rnicholus
Member

This is the last task scheduled for 5.5.0. I'll begin work on this next week.

@rnicholus
Member

When attempting to test out the DnD feature in Edge, I noticed that the available Windows 10 VMs only support Edge 10240. I reached out to the Edge team, and they informed me that indeed there is no support for 10565 in Windows 10 VMs at the moment. No known date for release of a VM with this build of Edge. So, I'll need to remove this from the schedule yet again.

@rnicholus rnicholus removed this from the 5.5.0 milestone Jan 8, 2016
@JW301
JW301 commented Mar 19, 2016

Still not working in Edge. The drop-zone appears and immediately disappears when dragging a file onto the browser window, flickering when moving the file around. Dropping does not work.

BUT, when I manually remove the "display: none;" from the drop-zone in developer tools, I'm able to drag a file onto it and have it uploaded, without any problems and no flickering of the drop zone. The drop zone then disappears after the upload as normal.

Any chance you could fix this?

@rnicholus
Member

Edge is not yet supported by Fine Uploader. This has not been possible for various reasons (all on the Microsoft side). Edge didn't even support file dropping until a few months ago, and then there was no VM available with the build of edge that included support for file dropping. I'll check again to see if there is an updated VM. If there is, I'll try to add edge support again.

@JW301
JW301 commented Mar 19, 2016

good news :) I checked the code myself and found a solution for DnD

The problem is not in the DnD module itself, that one is fully working. The problem is in the browser being incorrectly detected as Firefox, while not all Firefox features seem to work.
This same problem seems to have happened with IE11 in the beginning. See master/client/js/util.js line 554:

qq.firefox = function() {
return (!qq.ie11() && navigator.userAgent.indexOf("Mozilla") !== -1 && navigator.vendor !== undefined && navigator.vendor === "");
};

Here you explicitly say it is not Firefox if it is also IE11. You just need to do the same thing with Edge
So I added another function to identify Edge and then changed the Firefox function as following:

qq.edge = function() {
return navigator.vendor === "" && navigator.userAgent.indexOf("Edge") !== -1;
};
qq.firefox = function() {
return (!qq.edge() && !qq.ie11() && navigator.userAgent.indexOf("Mozilla") !== -1 && navigator.vendor !== undefined && navigator.vendor === "");
};

With these lines changed, the DnD (and all other features I have used) work as expected.

Maybe you can use this information to fix the DnD problem in Edge :)

@rnicholus
Member

Thanks for looking into this! I'll take a closer look and add support for edge in a near future release.

@rnicholus
Member

Sorry, still blocked on this. Microsoft has still not released a VM with a current build of Edge. The latest one available is 10240, which does not support file dropping. Without that VM, there isn't much I can do here. I'd suggest pinging someone at Microsoft about this. I'm going to mention this to them again, as I did a couple months ago. Until a VM with Edge build 10565 or later is made available by Microsoft, Edge remains officially unsupported by Fine Uploader.

Thread on Twitter at https://twitter.com/kylealden/status/684893112355794945.

@rnicholus
Member

Microsoft tells me an updated VM will be available in a couple weeks.

@rnicholus
Member
rnicholus commented Apr 20, 2016 edited

I now have a VM to work with, so I'll begin investigating support for Edge. Once this is complete (assuming I don't run into any more blockers) this will be released as 5.7.0.

@rnicholus rnicholus added 3 - Doing and removed 4 - Blocked labels Apr 20, 2016
@rnicholus rnicholus added this to the 5.7.0 milestone Apr 20, 2016
@rnicholus rnicholus added a commit that referenced this issue Apr 20, 2016
@rnicholus rnicholus feat(Edge): DnD support for Microsoft Edge
Also adjusted an unreliable test. This was tested in Edge 13.10586.
#1422
9e06eed
@rnicholus
Member

PR to release Edge support is #1557. Anyone here interested in giving it a whirl to verify before I release?

@rnicholus rnicholus added 5 - Done and removed 3 - Doing labels Apr 20, 2016
@rnicholus
Member

This is completed and Microsoft Edge is now supported as of Fine Uploader 5.7.0.

@rnicholus rnicholus closed this Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment