Manual upload stops prematurely when lot of files are uploaded #1439

Closed
mohitjee15 opened this Issue Jul 23, 2015 · 14 comments

Projects

None yet

2 participants

@mohitjee15

In the demo page :- http://fineuploader.com/demos

I tried to upload near about 1800 files all pretty small less than 1 MB.

Once I click on Upload button it started uploading, but after 840 files the progress bar disappears and for the rest of the 760 files I have to click "Upload" button again.

We are also facing similar problem in our end.

@rnicholus
Member

Which browsers are you using to reproduce this? If I'm able to reproduce
myself, I'll look into a fix for 5.3.0.
On Thu, Jul 23, 2015 at 5:42 AM Mohit Suman notifications@github.com
wrote:

In the demo page :- http://fineuploader.com/demos

I tried to upload near about 1800 files all pretty small less than 1 MB.

Once I click on Upload button it started uploading, but after 840 files
the progress bar disappears and for the rest of the 760 files I have to
click "Upload" button again.

We are also facing similar problem in our end.


Reply to this email directly or view it on GitHub
#1439.

@rnicholus
Member

It's tough to reproduce something that requires 1800 files to be uploaded. I'm not seeing any issues in the develop branch. There were a couple potentially related issues fixed there, and they will be part of 5.3.0. Please let me know if the 5.3.0-8 build fixes your issue.

@mohitjee15

Chrome browser. Version 42 i think.
Which browsers are you using to reproduce this? If I'm able to reproduce
myself, I'll look into a fix for 5.3.0.
On Thu, Jul 23, 2015 at 5:42 AM Mohit Suman notifications@github.com
wrote:

In the demo page :- http://fineuploader.com/demos

I tried to upload near about 1800 files all pretty small less than 1 MB.

Once I click on Upload button it started uploading, but after 840 files
the progress bar disappears and for the rest of the 760 files I have to
click "Upload" button again.

We are also facing similar problem in our end.


Reply to this email directly or view it on GitHub
#1439.


Reply to this email directly or view it on GitHub
#1439 (comment)
.

@mohitjee15

When are you guys releasing 5.3.0 as it is in dev branch? Because till then it is a production bug for us.

One more thing what problems are you facing in uploading 1800 files?
We just copy pasted a bunch of files and were able to test it 5 mins.

@rnicholus
Member

5.3.0 is in develop. The latest build is 5.3.0-8. For information on how to
download the latest dev build of your choice, see my comment at
#1432 (comment)
On Fri, Jul 24, 2015 at 7:07 AM Mohit Suman notifications@github.com
wrote:

When are you guys releasing 5.3.0 as it is in dev branch? Because till
then it is a production bug for us.

One more thing what problems are you facing in uploading 1800 files?
We just copy pasted a bunch of files and were able to test it 5 mins.


Reply to this email directly or view it on GitHub
#1439 (comment)
.

@rnicholus
Member

5.3.0 will likely be released in the next week or two. In the meantime, you will want to ensure your issue is fixed in the pre-release before we actually release.

@rnicholus
Member

Everything is looking fine on my end on develop. Closing for now. I can re-open if you're able to reproduce on develop and have more specifics regarding reproduction.

@rnicholus rnicholus closed this Jul 29, 2015
@rnicholus
Member

After a few more attempts, I am now able to reproduce, though only after about 2700+ files.

@rnicholus rnicholus reopened this Jul 29, 2015
@rnicholus
Member

After further investigation, the issue occurs when a very large number of files is submitted and the uploadStoredFiles method is called before Fine Uploader has finished verifying all the files submitted. The files are only eligible for upload after various internal checks are run during a processing phase for each file that is submitted.

When uploadStoredFiles is called, it simply loops over an internal array of verified files and submits them to the upload controller to be queued or uploaded. When the issue described here occurs, this internal array does not yet contain all submitted files as not all submitted files have been verified. This also explains why calling uploadStoredFiles again later uploads the remaining files.

I think a reasonable solution may be to check if any files are still in the qq.status.SUBMITTING state once we finish iterating over the array of verified "stored" files to upload. If there are any files in this state, then we probably want to wait a bit and attempt to process items in the stored files array again.

@rnicholus rnicholus added this to the 5.3.0 milestone Jul 29, 2015
@rnicholus rnicholus added 5 - Done and removed 3 - Doing labels Jul 29, 2015
@rnicholus
Member

This is now fixed in the develop branch. Please verify on your end before release @mohitjee15.

Pre-release build number incremented to "-9" in b7053e5.

@rnicholus
Member

I just pushed the release candidate to npm: "fine-uploader@5.3.0-11".

@mohitjee15

ok i'll verify today and let you know.

@mohitjee15

Ok verified in chrome version 42, it works fine. My colleague checked it out @https://github.com/arpit2438735/

@rnicholus
Member

Thanks for the update. Looks like we're ready to release 5.3.0.
On Mon, Aug 3, 2015 at 6:07 AM Mohit Suman notifications@github.com wrote:

Ok verified in chrome version 42, it works fine. My colleague checked it
out @https://github.com/arpit2438735/


Reply to this email directly or view it on GitHub
#1439 (comment)
.

@rnicholus rnicholus closed this in 66e5016 Aug 3, 2015
@rnicholus rnicholus removed the 5 - Done label Aug 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment