Proper support for "standard" request headers/params when uploading to S3 #1494

Closed
rnicholus opened this Issue Nov 12, 2015 · 5 comments

Projects

None yet

2 participants

@rnicholus
Member

Work to support Cache-Control, Content-Disposition, Content-Encoding, Content-MD5, x-amz-server-side-encryption-customer-algorithm, x-amz-server-side-encryption-customer-key, and x-amz-server-side-encryption-customer-key-MD5 started with #1258, but there are still some issues that prevent use of these headers.

TODO:

  • Do not escape values for these fields. This type of escaping will, for example, break the Content-Disposition header. If any of these standardized header values needs to be encoded, the integrator must do so before passing the value on to Fine Uploader.
  • The header names are being converted to lower-case before deciding if they are custom. Since the list of standard/non-custom headers is mixed-case, we are still prefixing non-custom headers w/ x-amz-meta.
  • We need unit tests to cover use of some of these headers.
  • Documentation updates?
@rnicholus rnicholus added this to the 5.5.0 milestone Nov 12, 2015
@rnicholus
Member

Regarding header values of custom headers, I think the best approach is to simply leave these alone. If encoding is needed, the developer integrating with Fine Uploader S3 will need to properly encode these values before forwarding them on to Fine Uploader.

@rnicholus rnicholus added a commit that referenced this issue Dec 30, 2015
@rnicholus rnicholus feat(s3): don't encode, prefix, or lower-case certain params
TODO:
- unit tests
- doc updates
#1494
2a5f261
@rnicholus rnicholus added 3 - Doing and removed 2 - Do labels Dec 30, 2015
@rnicholus rnicholus added a commit that referenced this issue Dec 31, 2015
@rnicholus rnicholus docs(s3): header documentation section
#1494
[skip ci]
2c3ea6e
@rnicholus rnicholus added 5 - Done and removed 3 - Doing labels Dec 31, 2015
@rnicholus
Member

This has been completed and is available in the develop branch as 5.5.0-2. I plan to release this with 5.5.0.

@neilchaudhuri

What's the ballpark for the 5.5.0 release? Curious for my own migration planning purposes.

@rnicholus
Member

@neilchaudhuri I will be on a short vacation for most of this week, and I plan to release 5.5.0 mid-next week, perhaps around the 20th or 21st. If I run into issues during final testing, I'll aim for a release the following week, provided the issues encountered are not significant.

@rnicholus
Member

All tests are passing in all supported browsers, so the release of 5.5.0 next week is likely.

@rnicholus rnicholus added a commit that closed this issue Jan 19, 2016
@rnicholus rnicholus chore(build): inc build num
closes #1494
21feafb
@rnicholus rnicholus closed this in 21feafb Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment