This repository has been archived by the owner. It is now read-only.

Authorize fineUploader to send form even without file to upload #1971

Open
o3LL opened this Issue Feb 20, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@o3LL
Copy link

o3LL commented Feb 20, 2018

Hi !

Type of issue

  • Bug report
  • Feature request

Uploader type

  • Traditional
  • S3
  • Azure

Feature request details

FileUploader integration in a form (see) with optional file upload throw "No files to upload." on form submit when there is no file in FileUploader.

Change FileUploader form integration to act like an empty field instead.

Possible fix

Add an optional option in the FileUploader constructor or by default Existing HTML Forms integraton dont throw errors on upload if there is no file.

if (this._storedIds.length === 0) {

Thanks !

@rnicholus

This comment has been minimized.

Copy link
Member

rnicholus commented Feb 20, 2018

Would you like to try a pull request with the necessary changes? You'll need to write some tests as well to ensure this actually works. I'm not sure it will be trivial, but maybe?

@o3LL

This comment has been minimized.

Copy link

o3LL commented Feb 20, 2018

Sure, that's what I was planning to do. Just wanted to know if this feature was suitable in this project !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.