Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
onAutoRetry event should allow returning boolean to prevent further retries #2018
Type of issue
Feature RequestonAutoRetry should allow returning true/false to allow/prevent further retries
Feature request details
Sometimes logic on the client side will need to make decisions about whether to continue trying to upload a failed/failing upload. Currently there is no way to make intelligent decisions about when to keep retrying and when to fail the upload. We have to either set uploads retry attempts to 10000 and try forever or set it to 10 and possibly fail an upload on a poor connection even if it would have completed with more attempts.
There are many client side connection issues that can’t be solved from the developers end. What about especially large files on poor connections? Users don’t want to sit and stare at an upload screen for an hour clicking retry every time their connection gets reset. By allowing a Boolean return, devs can check other factors (to see if there is a connection at all, etc) and determine if the current upload should continue or fail.
Alternatively being able to set the upload status to upload_failed by api would work.