Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

feat(dnd.js): add dragEnter and dragLeave callbacks #2037

Merged
merged 4 commits into from Nov 1, 2018

Conversation

HerringtonDarkholme
Copy link
Contributor

Brief description of the changes

Currently fine-uploader dnd only toggles class name on targetElement. However, users need more advanced UI control when dragging/drop.

What browsers and operating systems have you tested these changes on?

Firefox

Have you written unit tests? If not, explain why.

No. I didn't find other callbacks for dnd like processingDroppedFilesComplete in unit test. So I think it might be better to ask maintainers how to add it.

@singhjusraj
Copy link
Member

@rnicholus this seems like something we can easily merge. Seems handy to have those two callbacks

@rnicholus
Copy link
Member

@SinghSukhdeep I no longer have any time to dedicate to this project, at all. You've been pretty attentive to the project, and perhaps you'd be interested in taking over. If so, let me know and I'll make sure you have all of the appropriate permissions. I'd still be available if you have questions, but turnaround time might not be ideal.

@singhjusraj
Copy link
Member

I hear you, I will look at this closely soon and will try my best

@singhjusraj singhjusraj self-assigned this Oct 4, 2018
@HerringtonDarkholme
Copy link
Contributor Author

Thank you for taking up the project!

@singhjusraj
Copy link
Member

Hoping to get some time soon to look at all the pending PRs

@singhjusraj
Copy link
Member

Everything looks good.
This also requires docs update for drag and drop page
Can you please add that as well and I'll merge this

Copy link
Member

@singhjusraj singhjusraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires docs updates as well

@singhjusraj singhjusraj merged commit 15fb63a into FineUploader:master Nov 1, 2018
@HerringtonDarkholme
Copy link
Contributor Author

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants