This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
feat(dnd.js): add dragEnter and dragLeave callbacks #2037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes
Currently fine-uploader dnd only toggles class name on targetElement. However, users need more advanced UI control when dragging/drop.
What browsers and operating systems have you tested these changes on?
Firefox
Have you written unit tests? If not, explain why.
No. I didn't find other callbacks for dnd like
processingDroppedFilesComplete
in unit test. So I think it might be better to ask maintainers how to add it.