From 2a3323f3b767b00d7ecf8d5acb1ad80fc4d7e3b5 Mon Sep 17 00:00:00 2001
From: jfarr095 <jfarr095@uottawa.ca>
Date: Fri, 16 Aug 2019 13:51:28 -0400
Subject: [PATCH] Equipped Weapon Skills

Reads last byte in item data as a skill. Skill is only active when item is active.
Credit to Kirb.
---
 .../SkillSystem/Internals/SkillSystem.event   |   1 +
 .../SkillSystem/Internals/skillTester.dmp     | Bin 40 -> 68 bytes
 .../SkillSystem/Internals/skillTester.s       |  35 ++++++++++++++----
 .../Item editors/FE8 Item Editor.csv          |   2 +-
 4 files changed, 30 insertions(+), 8 deletions(-)

diff --git a/Engine Hacks/SkillSystem/Internals/SkillSystem.event b/Engine Hacks/SkillSystem/Internals/SkillSystem.event
index ca743e62bd..8143c5e7d1 100644
--- a/Engine Hacks/SkillSystem/Internals/SkillSystem.event	
+++ b/Engine Hacks/SkillSystem/Internals/SkillSystem.event	
@@ -68,6 +68,7 @@ Skill_Getter: // gets a list of skills
 SkillTesterOriginal: //does unit have X skill?
 #incbin skillTester.dmp
 POIN Skill_Getter
+POIN ItemTable
 
 SkillTester: //does enemy have Nihil? if so, does Nihil negate X skill?
 #incbin nihilTester.dmp
diff --git a/Engine Hacks/SkillSystem/Internals/skillTester.dmp b/Engine Hacks/SkillSystem/Internals/skillTester.dmp
index e324c205a6778d04aad7763595d6d4baca2a27bd..134691caaaff17b720bf739feda6119b4b7b3685 100644
GIT binary patch
literal 68
zcmXrm$|}R4DShF;ruYRO8D7smH-;aK6%3lp7Zy4RTwpZ#@%%;ie?<-l1`YNLDvBP?
Xtey@M%8Cv#3!E4)Fen)8WdvdX|4<dW

literal 40
tcmWgG%Am<};Xe@b$gp|#xiS1;tYFY&y|B=U@dBg4kLQdE0(%*N7yt@)4JZHr

diff --git a/Engine Hacks/SkillSystem/Internals/skillTester.s b/Engine Hacks/SkillSystem/Internals/skillTester.s
index 3bb67878e7..784ea1bbc8 100644
--- a/Engine Hacks/SkillSystem/Internals/skillTester.s	
+++ b/Engine Hacks/SkillSystem/Internals/skillTester.s	
@@ -4,10 +4,14 @@
 
 @TODO: also check inventory for skill items?
 
+.set GetUnitEquippedItem, 0x8016B28
+.set ItemTable, SkillGetter+0x04
+
 .thumb
 
-push {r4,lr}
+push {r4-r5,lr}
 @r0 has unit data
+mov r5, r0
 cmp r1, #0
 beq True
 cmp r1, #0xFF
@@ -20,20 +24,37 @@ mov lr, r1
 @now r0 is the buffer to loop through
 Loop:
 ldrb r1, [r0]
-cmp r1, #0
-beq False
+cmp r1, #0 @list is over, now test if the equipped item has a skill
+beq TestEquippedItem
 cmp r1, r4
 beq True
 add r0, #1
 b Loop
 
-True:
-mov r0, #1
-pop {r4,pc}
+TestEquippedItem:
+ldrh r0, [r5, #0x1E]
+mov r1, #0xFF @get the item id
+and r0, r1
+cmp r0, #0
+beq False
+mov r1, #36 @size of the item table
+mul r0, r1
+ldr r1, ItemTable
+add r0, r1 
+mov r1, #35 @last byte in the item table
+ldrb r0, [r0, r1]
+cmp r0, r4
+beq True
 
 False:
 mov r0, #0
-pop {r4,pc}
+pop {r4-r5, pc}
+
+True:
+mov r0, #1
+pop {r4-r5, pc}
+
+.pool
 
 SkillGetter:
 @POIN SkillGetter
diff --git a/Tables/FE8 Nightmare modules/Item editors/FE8 Item Editor.csv b/Tables/FE8 Nightmare modules/Item editors/FE8 Item Editor.csv
index 9a91428c36..b45dc5d654 100644
--- a/Tables/FE8 Nightmare modules/Item editors/FE8 Item Editor.csv	
+++ b/Tables/FE8 Nightmare modules/Item editors/FE8 Item Editor.csv	
@@ -1,4 +1,4 @@
-0x809b10,Item Name,Item Description,Use Item Description,Item Number,Weapon Type,Weapon Ability 1,Weapon Ability 2,Weapon Ability 3,Weapon Ability 4,Stat Bonuses Pointer,Effectiveness Pointer,Durability,Power,Hit%,Weight,Critical%,Minimum - Maximum Range,Cost Per Use (0 = Unsellable),Weapon Rank,Item Icon #,Staff/Use Effect,Weapon Effect,Weapon Experience,DebuffType,***UNKNOWN*** (Zero),***UNKNOWN*** (Zero)
+0x809b10,Item Name,Item Description,Use Item Description,Item Number,Weapon Type,Weapon Ability 1,Weapon Ability 2,Weapon Ability 3,Weapon Ability 4,Stat Bonuses Pointer,Effectiveness Pointer,Durability,Power,Hit%,Weight,Critical%,Minimum - Maximum Range,Cost Per Use (0 = Unsellable),Weapon Rank,Item Icon #,Staff/Use Effect,Weapon Effect,Weapon Experience,DebuffType,***UNKNOWN*** (Zero),Item Skill
 Nothing,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0x0,0,0,0,0,0,0x0,0,0,0x0,0x0,0,0,0,0,0
 Iron Sword,0x354,0x404,0x0,0x1,0x0,0x1,0x0,0x0,0x0,0x0,0x0,46,5,90,5,0,0x11,10,1,0x0,0x0,0,2,0,0,0
 Slim Sword,0x355,0x405,0x0,0x2,0x0,0x1,0x0,0x0,0x0,0x0,0x0,30,3,100,2,5,0x11,16,1,0x1,0x0,0,2,0,0,0