Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Github Action Logs Look Corrupted #188

Closed
Aedalus opened this issue Jan 9, 2022 · 14 comments
Closed

[BUG] Github Action Logs Look Corrupted #188

Aedalus opened this issue Jan 9, 2022 · 14 comments
Labels
bug Something isn't working

Comments

@Aedalus
Copy link

Aedalus commented Jan 9, 2022

Action config

Created a brand new Github workflow via the firebase CLI. No modifications were made to the workflow, and the firebase project has worked fine before setting up CI/CD.

    steps:
      - uses: actions/checkout@v2
      - run: npm ci && npm run build
      - uses: FirebaseExtended/action-hosting-deploy@v0
        with:
          repoToken: '${{ secrets.GITHUB_TOKEN }}'
          firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_MY_PROJECT}}'
          channelId: live
          projectId: <my-project>

Error message

During the deploy step, logs look like some form of encoding/coloring got messed up. Logs also increased to over 750MB total, slowing the github UI to a crawl. This recent issue seems to point towards recent issues with a 'Faker' package being the cause, but it's not clear to me if that is the case. Would prefer if we could leave a bug report open to help track the issue, and allow others to find some information if seeing similar problems.

image

@Aedalus Aedalus added the bug Something isn't working label Jan 9, 2022
@sagearora
Copy link

Same issue on my deploys starting today!

@khromov
Copy link

khromov commented Jan 10, 2022

Same issue here on existing app that has been deploying without problems for several weeks.

@regulait-dev
Copy link

Same problem starting today

@Andrew-Hopkins-Liqua
Copy link

I am having the same issue.
This is a game-breaking bug.

I believe this issue is related to the Marak Zalgo Liberty 2 bug.
https://snyk.io/blog/open-source-maintainer-pulls-the-plug-on-npm-packages-colors-and-faker-now-what/
Marak/colors.js#285

@elsowiny
Copy link

elsowiny commented Jan 10, 2022

I am having the same issue. This is a game-breaking bug.

I believe this issue is related to the Marak Zalgo Liberty 2 bug. https://snyk.io/blog/open-source-maintainer-pulls-the-plug-on-npm-packages-colors-and-faker-now-what/ Marak/colors.js#285

yes I think it has to do with this

@joshkautz
Copy link

Having this issue too. Yikes!

@Andrew-Hopkins-Liqua
Copy link

Andrew-Hopkins-Liqua commented Jan 10, 2022

@jhuleatt Is there anything we can do to avoid the colors library and fastpace this issue until Marak finishes his protest?
I believe this is the dependency tree that is causing this issue

  • Action-hosting-deploy
    • Firebase-tools
      • cli-table
        • colors (subdependancy which is causing the issue)
      • winston
        • logform
          • colors (subdependancy which is causing the issue)

@Andrew-Hopkins-Liqua
Copy link

update: winstonJS, and logformJS have pinned the colors package to 1.4.0 to avoid the security vulnerability.

My GitHub actions are now working again (albeit with a lot of depreciation warnings)

@anthonyjdella
Copy link

anthonyjdella commented Jan 10, 2022

Just replying because I'm also having the same issue. It is causing my deploy to fail 😢

Edit: It works now, as of 8:20PM CST. Thanks Andrew!

@Andrew-Hopkins-Liqua
Copy link

It works now, as of 8:20PM CST. Thanks Andrew!

I'm happy to be a messenger of good news!
but just to be clear: I'm not a maintainer of any of these repo's . just a fellow dev who was impacted by the Liberty 2 issue

@elsowiny
Copy link

update: winstonJS, and logformJS have pinned the colors package to 1.4.0 to avoid the security vulnerability.

My GitHub actions are now working again (albeit with a lot of depreciation warnings)

thank you for the updates!

@jhuleatt
Copy link
Collaborator

jhuleatt commented Jan 10, 2022

Thanks for the helpful information @Andrew-Hopkins-Liqua. To tie things together, here's the bug in the Firebase CLI repo: firebase/firebase-tools#3999

@sfxoodeyemi
Copy link

I'm experiencing this in my nestjs app. I get this on the aws build console.

@jhuleatt
Copy link
Collaborator

This was fixed in the Firebase CLI in firebase/firebase-tools#4004

@FirebaseExtended FirebaseExtended locked and limited conversation to collaborators Mar 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants