From 6ff112f1071a221eedb2496dcefe9621583c3e98 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 20 Dec 2023 15:22:12 -0500 Subject: [PATCH 1/3] Update CODEOWNERS --- CODEOWNERS | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CODEOWNERS b/CODEOWNERS index dc8494fe..84ff7848 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,2 +1,5 @@ -/packages/adapter-*/ @Yuangwang +/packages/@apphosting/adapter-*/ @Yuangwang +/packages/@apphosting/build/ @jamesdaniels +/packages/@apphosting/create/ @jamesdaniels +/packages/@apphosting/discover/ @jamesdaniels /packages/firebase-frameworks/ @jamesdaniels From 7c15ca1535f3b19c4e00e56e16ef750a15746345 Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 20 Dec 2023 15:24:26 -0500 Subject: [PATCH 2/3] Add leo and sijin --- CODEOWNERS | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index 84ff7848..da2cacce 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,5 +1,5 @@ -/packages/@apphosting/adapter-*/ @Yuangwang -/packages/@apphosting/build/ @jamesdaniels -/packages/@apphosting/create/ @jamesdaniels -/packages/@apphosting/discover/ @jamesdaniels -/packages/firebase-frameworks/ @jamesdaniels +/packages/@apphosting/adapter-*/ @Yuangwang @sjjj986 +/packages/@apphosting/build/ @jamesdaniels @leoortizz +/packages/@apphosting/create/ @jamesdaniels @leoortizz +/packages/@apphosting/discover/ @jamesdaniels @leoortizz +/packages/firebase-frameworks/ @jamesdaniels @leoortizz From 147a69a0b732dcefba3d701aa82dbcf40e2727cb Mon Sep 17 00:00:00 2001 From: James Daniels Date: Wed, 20 Dec 2023 15:39:49 -0500 Subject: [PATCH 3/3] Use group names --- CODEOWNERS | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/CODEOWNERS b/CODEOWNERS index da2cacce..36369f9d 100644 --- a/CODEOWNERS +++ b/CODEOWNERS @@ -1,5 +1,13 @@ +# Global reviewers +# TODO add group for global reviewers +* @jamesdaniels @leoortizz @Yuangwang @sjjj986 + +# App Hosting Platform Adapters code +# TODO add group for App Hosting /packages/@apphosting/adapter-*/ @Yuangwang @sjjj986 -/packages/@apphosting/build/ @jamesdaniels @leoortizz -/packages/@apphosting/create/ @jamesdaniels @leoortizz -/packages/@apphosting/discover/ @jamesdaniels @leoortizz -/packages/firebase-frameworks/ @jamesdaniels @leoortizz + +# Web Frameworks code +/packages/@apphosting/build/ @FirebaseExtended/firebase-full-time-employees @FirebaseExtended/monogram +/packages/@apphosting/create/ @FirebaseExtended/firebase-full-time-employees @FirebaseExtended/monogram +/packages/@apphosting/discover/ @FirebaseExtended/firebase-full-time-employees @FirebaseExtended/monogram +/packages/firebase-frameworks/ @FirebaseExtended/firebase-full-time-employees @FirebaseExtended/monogram