From 66fa0b1b938ce29ba7e37691edaf5b900d7573f9 Mon Sep 17 00:00:00 2001 From: Wei Wang Date: Thu, 29 Feb 2024 11:45:30 -0500 Subject: [PATCH 1/5] break test --- packages/@apphosting/adapter-angular/src/bin/build.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@apphosting/adapter-angular/src/bin/build.spec.ts b/packages/@apphosting/adapter-angular/src/bin/build.spec.ts index c89c683d..4fac56a5 100644 --- a/packages/@apphosting/adapter-angular/src/bin/build.spec.ts +++ b/packages/@apphosting/adapter-angular/src/bin/build.spec.ts @@ -41,7 +41,7 @@ runCommand: node .apphosting/dist/server/server.mjs neededDirs: - .apphosting staticAssets: - - .apphosting/dist/browser + - .apphosting/dist/break `, }; validateTestFiles(tmpDir, expectedFiles); From da93a14f235875417f8208ac3175d8ebc7c1a3f3 Mon Sep 17 00:00:00 2001 From: Wei Wang Date: Thu, 29 Feb 2024 12:17:27 -0500 Subject: [PATCH 2/5] Report exit code --- scripts/test.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/test.js b/scripts/test.js index bb5b34bb..4aea610a 100755 --- a/scripts/test.js +++ b/scripts/test.js @@ -2,4 +2,9 @@ const { spawn } = require("child_process"); const { lernaScopeArgs } = require("./github.js"); -spawn("lerna", ["run", "test", "--verbose", "--no-bail", ...lernaScopeArgs], { stdio: "inherit" }); +const testProcess = spawn("lerna", ["run", "test", "--verbose", "--no-bail", ...lernaScopeArgs], { + stdio: "inherit", +}); +testProcess.on("close", (code) => { + process.exit(code); +}); From 85c722abf344c0376e861c05fe8b6fcd89515a45 Mon Sep 17 00:00:00 2001 From: Wei Wang Date: Thu, 29 Feb 2024 12:18:29 -0500 Subject: [PATCH 3/5] fix test --- packages/@apphosting/adapter-angular/src/bin/build.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@apphosting/adapter-angular/src/bin/build.spec.ts b/packages/@apphosting/adapter-angular/src/bin/build.spec.ts index 4fac56a5..c89c683d 100644 --- a/packages/@apphosting/adapter-angular/src/bin/build.spec.ts +++ b/packages/@apphosting/adapter-angular/src/bin/build.spec.ts @@ -41,7 +41,7 @@ runCommand: node .apphosting/dist/server/server.mjs neededDirs: - .apphosting staticAssets: - - .apphosting/dist/break + - .apphosting/dist/browser `, }; validateTestFiles(tmpDir, expectedFiles); From 078cbd463832618e1e291f35f504d2f5d1c1bb7f Mon Sep 17 00:00:00 2001 From: Wei Wang Date: Thu, 29 Feb 2024 11:04:11 -0800 Subject: [PATCH 4/5] fix tests --- packages/@apphosting/adapter-angular/package.json | 10 +++++----- .../@apphosting/adapter-angular/src/bin/build.spec.ts | 1 + 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/packages/@apphosting/adapter-angular/package.json b/packages/@apphosting/adapter-angular/package.json index 1e89e0cb..8e1018d0 100644 --- a/packages/@apphosting/adapter-angular/package.json +++ b/packages/@apphosting/adapter-angular/package.json @@ -46,17 +46,17 @@ "zod": "^3.22.4" }, "peerDependencies": { - "@angular-devkit/architect": "~0.1700.0", - "@angular-devkit/core": "~17.0.0" + "@angular-devkit/architect": "~0.1702.0", + "@angular-devkit/core": "~17.2.0" }, "peerDependenciesMeta": { "@angular-devkit/architect": { "optional": true }, "@angular-devkit/core": { "optional": true } }, "devDependencies": { - "@angular-devkit/architect": "~0.1700.0", - "@angular-devkit/core": "~17.0.0", - "@angular/core": "~17.0.0", + "@angular-devkit/architect": "~0.1702.0", + "@angular-devkit/core": "~17.2.0", + "@angular/core": "~17.2.0", "@types/fs-extra": "*", "@types/mocha": "*", "@types/tmp": "*", diff --git a/packages/@apphosting/adapter-angular/src/bin/build.spec.ts b/packages/@apphosting/adapter-angular/src/bin/build.spec.ts index c89c683d..97e65cfa 100644 --- a/packages/@apphosting/adapter-angular/src/bin/build.spec.ts +++ b/packages/@apphosting/adapter-angular/src/bin/build.spec.ts @@ -56,6 +56,7 @@ staticAssets: outputBaseDirectory: resolve(".apphosting", "dist"), outputDirectory: resolve("", ".apphosting"), serverFilePath: resolve(".apphosting", "server", "server.mjs"), + needsServerGenerated: false, }; const outputPaths = { root: new URL("file:///test"), From b5ec9675756460f688f9ec5aec5bb45d4ea754e9 Mon Sep 17 00:00:00 2001 From: Wei Wang Date: Thu, 29 Feb 2024 11:06:22 -0800 Subject: [PATCH 5/5] fix tests --- packages/@apphosting/adapter-angular/src/bin/create.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/@apphosting/adapter-angular/src/bin/create.ts b/packages/@apphosting/adapter-angular/src/bin/create.ts index 609ade55..d0b9a5ea 100644 --- a/packages/@apphosting/adapter-angular/src/bin/create.ts +++ b/packages/@apphosting/adapter-angular/src/bin/create.ts @@ -3,7 +3,7 @@ import { spawn } from "child_process"; import { isMain } from "../utils.js"; -export const ANGULAR_CLI_VERSION = "~17.0.0"; +export const ANGULAR_CLI_VERSION = "~17.2.0"; const main = isMain(import.meta);